8281170: Test jdk/tools/jpackage/windows/WinInstallerIconTest always fails on Windows 11

[alexeysemenyukoracle]

Code clean up. Remove obsolete comments, unused imports, and unneeded jtreg test parameter.
Fix the code to handle the case when installers are not created and there is nothing to verify in the test.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8281170: Test jdk/tools/jpackage/windows/WinInstallerIconTest always fails on Windows 11

Reviewers

• Alexander Matveev (@sashamatveev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7481/head:pull/7481
$ git checkout pull/7481

Update a local copy of the PR:
$ git checkout pull/7481
$ git pull https://git.openjdk.java.net/jdk pull/7481/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7481

View PR using the GUI difftool:
$ git pr show -t 7481

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7481.diff

[bridgekeeper]

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (75f7fde8)

[openjdk]

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281170: Test jdk/tools/jpackage/windows/WinInstallerIconTest always fails on Windows 11

Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 362 new commits pushed to the master branch:

• 0af356b: 8278173: [vectorapi] Add x64 intrinsics for unsigned (zero extended) casts
• a24498b: 8281771: Crash in java_lang_invoke_MethodType::print_signature
• 1aff44b: 8279949: JavaThread::_free_handle_block leaks native memory
• 394ce5f: 8280825: Modules that "provide" ToolProvider should document the name that can be used
• 745f7e7: 8281186: runtime/cds/appcds/DumpingWithNoCoops.java fails
• 1870465: 8281744: x86: Use short jumps in TIG::set_vtos_entry_points
• 2fe0bf6: 8281748: runtime/logging/RedefineClasses.java failed "assert(addr != __null) failed: invariant"
• bc61484: 8280136: Serial: Remove unnecessary use of ExpandHeap_lock
• 2112a9d: 8246033: bin/print_config.js script uses nashorn jjs tool
• 1c12b15: 8281741: [testbug] PrintIdealPhaseTest fails with -Xcomp
• ... and 352 more: https://git.openjdk.java.net/jdk/compare/46fd683820bb7149c0605a0ba03f59e76de69c16...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[alexeysemenyukoracle]

/integrate

[openjdk]

Going to push as commit bb4dece.
Since your change was applied there have been 370 commits pushed to the master branch:

• 9b74c3f: 8176706: Additional Date-Time Formats
• 0f3d3ac: 8061729: Update java/net tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs
• 395bc14: 8281732: add assert for non-NULL assumption for return of unique_ctrl_out
• d8f44aa: 8278067: Make HttpURLConnection default keep alive timeout configurable
• 7428b37: 8281948: JFR: Parser skips too many bytes for fractional types
• d5b4666: 8281829: runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java fails after JDK-8281467
• fef5d74: 8281812: x86: Use short jumps in TemplateTable::condy_helper
• a86cab8: 8236136: tests which use CompilationMode shouldn't be run w/ TieredStopAtLevel
• 0af356b: 8278173: [vectorapi] Add x64 intrinsics for unsigned (zero extended) casts
• a24498b: 8281771: Crash in java_lang_invoke_MethodType::print_signature
• ... and 360 more: https://git.openjdk.java.net/jdk/compare/46fd683820bb7149c0605a0ba03f59e76de69c16...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexeysemenyukoracle Pushed as commit bb4dece.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.