Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8255026: C2: Miscellaneous cleanups in Compile and PhaseIdealLoop code #749

Closed
wants to merge 1 commit into from

Conversation

@iwanowww
Copy link

@iwanowww iwanowww commented Oct 19, 2020

Miscellaneous cleanups in Compile and PhaseIdealLoop code.

Compile:

  • inline node lists

  • remove empty Compile::register_library_intrinsics()

  • introduce Compile::remove_useless_nodes(GrowableArray<Node*>& node_list, Unique_Node_List& useful)

PhaseIdealLoop:

  • unify logging and IGVN logic

  • refactor logging code

Testing: tier1 - tier5


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8255026: C2: Miscellaneous cleanups in Compile and PhaseIdealLoop code

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/749/head:pull/749
$ git checkout pull/749

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 19, 2020

👋 Welcome back vlivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Oct 19, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2020

@iwanowww The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 19, 2020

Webrevs

Loading

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Nice cleanup! Looks good to me.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 20, 2020

@iwanowww This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255026: C2: Miscellaneous cleanups in Compile and PhaseIdealLoop code

Reviewed-by: thartmann, neliasso, redestad

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

  • 294e070: 8254998: C2: assert(!n->as_Loop()->is_transformed_long_loop()) failure with -XX:StressLongCountedLoop=1
  • 3ee0380: 8234393: [macos] printing ignores printer tray
  • 3f9c8a3: 8254966: Remove unused code from Matcher
  • 21e67e5: 8225790: Two NestedDialogs tests fail on Ubuntu
  • 017d151: 8254842: [JVMCI] copy thread name when attaching libgraal thread to HotSpot
  • 5d1397f: 8254282: Add Linux x86_32 builds to submit workflow
  • 7ba6a6b: 8251158: Implementation of JEP 387: Elastic Metaspace
  • 5fedfa7: 8251271: C2: Compile::_for_igvn list is corrupted after RenumberLiveNodes
  • 98ec4a6: 8254805: compiler/debug/TestStressCM.java is still failing
  • 355f44d: 8254994: [x86] C1 StubAssembler::call_RT, "call_offset might not be initialized"
  • ... and 16 more: https://git.openjdk.java.net/jdk/compare/60f63ec811d834d9f1a7468a5552ffa12568b765...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Oct 20, 2020
Copy link
Contributor

@neliasso neliasso left a comment

Looks good.

Loading

cl4es
cl4es approved these changes Oct 20, 2020
@iwanowww
Copy link
Author

@iwanowww iwanowww commented Oct 21, 2020

Thanks for the reviews, Tobias, Nils, and Claes.

Loading

@iwanowww
Copy link
Author

@iwanowww iwanowww commented Oct 21, 2020

/integrate

Loading

@openjdk openjdk bot closed this Oct 21, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 21, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 21, 2020

@iwanowww Since your change was applied there have been 71 commits pushed to the master branch:

  • c107178: 8253964: [Graal] UnschedulableGraphTest#test01fails with expected:<4> but was:<3>
  • bd45191: 8255065: Zero: accessor_entry misses the IRIW case
  • 2a06335: 8254785: compiler/graalunit/HotspotTest.java failed with "missing Graal intrinsics for: java/lang/StringLatin1.indexOfChar([BIII)I"
  • 1b7ddeb: 8254976: Re-enable swing jtreg tests which were broken due to samevm mode
  • 2e510e0: 8255043: Incorrectly styled copyright text
  • 6bd05b1: 8255074: sun.nio.fs.WindowsPath::getPathForWin32Calls synchronizes on String object
  • 9e9f5e6: 8017179: [macosx] list1 and list2 vistble item isn't desired
  • 2ee2b4a: 8231454: File lock in Windows on a loaded jar due to a leak in Introspector::getBeanInfo
  • 42a6ead: 8254884: Make sure jvm does not crash with Arm SVE and Vector API
  • e5870cf: 8252133: The java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java fails if metal pipeline is active
  • ... and 61 more: https://git.openjdk.java.net/jdk/compare/60f63ec811d834d9f1a7468a5552ffa12568b765...master

Your commit was automatically rebased without conflicts.

Pushed as commit 27230fa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@iwanowww iwanowww deleted the 8255026 branch Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants