8281988: Create a test to check the JList selection while typing a letter accompanied by modifier keys

[manukumarvs]

Create a regression test for JDK-4618767

Issue identified in JDK-4618767:
Typing a letter while a JList has focus now makes the selection jump to the first/next node/item whose text starts with that letter even though that letter is accompanied by modifier keys such as ALT or CTRL.

Fix:
Only enable JList letter navigation when the user
doesn't press any modifier keys such as ALT or CTRL.

Testing:
I have verified this test with JDK 1.4.0 and JDK 1.4.1 .
The issue is reproducible using the test with JDK 1.4.0 , where the bug was originally reported and the test passed in JDK 1.4.1 where the issue was fixed.
I have tested it in Mac and Windows platforms multiple times and it passed everywhere.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8281988: Create a regression test for JDK-4618767

Reviewers

• Alexey Ivanov (@aivanov-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7496/head:pull/7496
$ git checkout pull/7496

Update a local copy of the PR:
$ git checkout pull/7496
$ git pull https://git.openjdk.java.net/jdk pull/7496/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7496

View PR using the GUI difftool:
$ git pr show -t 7496

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7496.diff

[bridgekeeper]

👋 Welcome back mvs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@manukumarvs The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 05: Full - Incremental (44225919)
• 04: Full - Incremental (58111fce)
• 03: Full - Incremental (259eb393)
• 02: Full - Incremental (5f9bb9e9)
• 01: Full - Incremental (d9583599)
• 00: Full (ae5ad5f8)

[manukumarvs]

@aivanov-jdk Can you please review this.

[aivanov-jdk]

Looks good overall except for the two comments.

[openjdk]

@manukumarvs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281988: Create a regression test for JDK-4618767

Reviewed-by: aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 97 new commits pushed to the master branch:

• e1060be: 8281615: Deadlock caused by jdwp agent
• 6f882de: 8280964: [Linux aarch64] : drawImage dithers TYPE_BYTE_INDEXED images incorrectly
• 2557ef8: 8282276: Problem list failing two Robot Screen Capture tests
• 6445ee4: 5041655: (ch) FileLock: negative param and overflow issues
• 7feabee: 8261407: ReflectionFactory.checkInitted() is not thread-safe
• 58e1882: 8282042: [testbug] FileEncodingTest.java depends on default encoding
• 3cb3867: 8281315: Unicode, (?i) flag and backreference throwing IndexOutOfBounds Exception
• 957dae0: 8280958: G1/Parallel: Unify marking code structure
• e44d067: 8244593: Clean up GNM/NM after JEP 381
• 41355e2: 8276686: Malformed Javadoc inline tags in JDK source in /java/util/regex/Pattern.java
• ... and 87 more: https://git.openjdk.java.net/jdk/compare/f07b8165231799383303e5c0755d07afd2feb7fd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[manukumarvs]

/integrate

[openjdk]

@manukumarvs
Your change (at version 58111fc) is now ready to be sponsored by a Committer.

[manukumarvs]

/integrate

[openjdk]

@manukumarvs
Your change (at version 4422591) is now ready to be sponsored by a Committer.

[aivanov-jdk]

/sponsor

[openjdk]

Going to push as commit 43dc9ef.
Since your change was applied there have been 111 commits pushed to the master branch:

• 253cf78: 8282076: Merge some debug agent changes from the loom repo
• f86f38a: 8280901: MethodHandle::linkToNative stub is missing w/ -Xint
• e540e0a: 8282296: (se) Pipe.open() creates a Pipe implementation that uses Unix domain sockets (win)
• 7dc7184: 8282309: Operation before upper case conversion
• a020b6b: 8280409: JarFile::getInputStream can fail with NPE accessing ze.getName()
• 99b8ed9: 8281217: Source file launch with security manager enabled fails
• 35076af: 8281376: Consider polymorphic methods when looking for overrides
• 340a35d: 8282279: Interpret case-insensitive string locale independently
• 5035bf5: 8282208: Reduce MachNode size
• aaab2cb: 8282225: GHA: Allow one concurrent run per PR only
• ... and 101 more: https://git.openjdk.java.net/jdk/compare/f07b8165231799383303e5c0755d07afd2feb7fd...master

Your commit was automatically rebased without conflicts.

[openjdk]

@aivanov-jdk @manukumarvs Pushed as commit 43dc9ef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.