Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8282011: test/jdk/tools/jpackage/windows/WinL10nTest.java test fails if light.exe is not in %PATH% #7500

Closed

Conversation

alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Feb 16, 2022


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8282011: test/jdk/tools/jpackage/windows/WinL10nTest.java test fails if light.exe is not in %PATH%

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7500/head:pull/7500
$ git checkout pull/7500

Update a local copy of the PR:
$ git checkout pull/7500
$ git pull https://git.openjdk.java.net/jdk pull/7500/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7500

View PR using the GUI difftool:
$ git pr show -t 7500

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7500.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 16, 2022

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 16, 2022

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org rfr Pull request is ready for review labels Feb 16, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 16, 2022

Webrevs

@alexeysemenyukoracle
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 16, 2022

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282011: test/jdk/tools/jpackage/windows/WinL10nTest.java test fails if light.exe is not in %PATH%

Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 378 new commits pushed to the master branch:

  • 5ec7898: 8281671: Class.getCanonicalName spec should explicitly cover array classes
  • 9ba0760: 8275345: RasterFormatException when drawing a tiled image made of non-writable rasters
  • 48f6e93: 8282020: ProblemList sun/net/www/protocol/https/HttpsURLConnection/B6216082.java until JDK-8282017 is fixed
  • 67763df: 8281003: MethodHandles::lookup throws NPE if caller is null
  • 847a99b: 8281822: Test failures on non-DTrace builds due to incomplete DTrace* flags handling
  • 980d187: 8281335: Allow a library already loaded via System::loadLibrary to be loaded as a raw library
  • 8164552: 8281874: Can't unpack msi installers from test/jdk/tools/jpackage/windows/test/jdk/tools/jpackage/windows/WinShortcutPromptTest.java test
  • bb4dece: 8281170: Test jdk/tools/jpackage/windows/WinInstallerIconTest always fails on Windows 11
  • 9b74c3f: 8176706: Additional Date-Time Formats
  • 0f3d3ac: 8061729: Update java/net tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs
  • ... and 368 more: https://git.openjdk.java.net/jdk/compare/46fd683820bb7149c0605a0ba03f59e76de69c16...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 16, 2022
@openjdk
Copy link

openjdk bot commented Feb 16, 2022

Going to push as commit 0b00ce1.
Since your change was applied there have been 378 commits pushed to the master branch:

  • 5ec7898: 8281671: Class.getCanonicalName spec should explicitly cover array classes
  • 9ba0760: 8275345: RasterFormatException when drawing a tiled image made of non-writable rasters
  • 48f6e93: 8282020: ProblemList sun/net/www/protocol/https/HttpsURLConnection/B6216082.java until JDK-8282017 is fixed
  • 67763df: 8281003: MethodHandles::lookup throws NPE if caller is null
  • 847a99b: 8281822: Test failures on non-DTrace builds due to incomplete DTrace* flags handling
  • 980d187: 8281335: Allow a library already loaded via System::loadLibrary to be loaded as a raw library
  • 8164552: 8281874: Can't unpack msi installers from test/jdk/tools/jpackage/windows/test/jdk/tools/jpackage/windows/WinShortcutPromptTest.java test
  • bb4dece: 8281170: Test jdk/tools/jpackage/windows/WinInstallerIconTest always fails on Windows 11
  • 9b74c3f: 8176706: Additional Date-Time Formats
  • 0f3d3ac: 8061729: Update java/net tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs
  • ... and 368 more: https://git.openjdk.java.net/jdk/compare/46fd683820bb7149c0605a0ba03f59e76de69c16...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 16, 2022
@openjdk openjdk bot closed this Feb 16, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 16, 2022
@openjdk
Copy link

openjdk bot commented Feb 16, 2022

@alexeysemenyukoracle Pushed as commit 0b00ce1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants