8281544: assert(VM_Version::supports_avx512bw()) failed for Tests jdk/incubator/vector/

[eme64]

ZSaveLiveRegisters::ZSaveLiveRegisters stores live registers, and later they are loaded again.
This includes opmask registers, which are part of AVX512. However, not all platforms have all of the AVX512 instructions.
For example Knights Landing has general AVX512 support and makes use of optmask registers, but does not support the AVX512 BW subset of instructions, specifically it does not support the kmovql instruction. Platforms like Cannon Landing have support for AVX512 BW.

Solution: in analogy to RegisterSaver::save_live_registers, which seems to perform a very similar task, use MacroAssembler::kmov instead of kmovql directly. Internally, kmov choses either kmovql if avx512bw is available, else it takes kmovwl.

As a regression test, I took one of the tests that failed with -XX:+UnlockExperimentalVMOptions -XX:+UseZGC, and added an additional @run statement with those flags. I simulated this test locally with Intel Software Development Emulator:
sde -knl: Knights Landing, AVX512 but not BW, fails without change to kmov, passes with it.
sde -cnl: Cannon Landing, has AVX512 BW, passes before and after code change.

Ran additional tests to verify that the test triggers before code change, and that with the code change nothing broke.

@neliasso Thanks for the help!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8281544: assert(VM_Version::supports_avx512bw()) failed for Tests jdk/incubator/vector/

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Nils Eliasson (@neliasso - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7510/head:pull/7510
$ git checkout pull/7510

Update a local copy of the PR:
$ git checkout pull/7510
$ git pull https://git.openjdk.java.net/jdk pull/7510/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7510

View PR using the GUI difftool:
$ git pr show -t 7510

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7510.diff

[bridgekeeper]

👋 Welcome back eme64! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@eme64 The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (7636119d)
• 00: Full (9e4169fb)

[vnkozlov]

Good.

[neliasso]

Looks good!

[openjdk]

@eme64 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281544: assert(VM_Version::supports_avx512bw()) failed for Tests jdk/incubator/vector/

Reviewed-by: kvn, neliasso, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 60 new commits pushed to the master branch:

• d7f31d0: 8282077: PKCS11 provider C_sign() impl should handle CKR_BUFFER_TOO_SMALL error
• d3749de: 8277488: Add expiry exception for Digicert (geotrustglobalca) expiring in May 2022
• 3943c89: 8282044: [JVMCI] Export _sha3_implCompress, _md5_implCompress and aarch64::_has_negatives stubs to JVMCI compiler.
• 7ce75af: 8255266: Update Public Suffix List to 3c213aa
• cfbfd9b: 8282103: fix macosx-generic typo in ProblemList
• 413bef6: 8282049: AArch64: Use ZR for integer zero immediate volatile stores
• cf6984d: 8282086: Update jib profile to not set build to 0
• f5120b7: 8282056: Clean up com.sun.tools.javac.util.GraphUtils
• e336504: 8280866: SuppressWarnings does not work properly in package-info and module-info
• e8224f7: 8282089: [BACKOUT] Parallel: Refactor PSCardTable::scavenge_contents_parallel
• ... and 50 more: https://git.openjdk.java.net/jdk/compare/f82866bc79cbeeac23716fa6fadd4877f5d0a462...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov, @neliasso, @TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[neliasso]

/label add hotspot-compiler

[openjdk]

@neliasso
The hotspot-compiler label was successfully added.

[TobiHartmann]

Looks good.

[eme64]

Thanks @neliasso @TobiHartmann @vnkozlov for the reviews!
/integrate

[openjdk]

@eme64
Your change (at version 7636119) is now ready to be sponsored by a Committer.

[TobiHartmann]

/sponsor

[openjdk]

Going to push as commit 4e0b81c.
Since your change was applied there have been 62 commits pushed to the master branch:

• 8563d86: 8282085: The REGISTER_DEFINITION macro is useless after JDK-8269122
• d28b048: 8281815: x86: Use short jumps in TIG::generate_slow_signature_handler
• d7f31d0: 8282077: PKCS11 provider C_sign() impl should handle CKR_BUFFER_TOO_SMALL error
• d3749de: 8277488: Add expiry exception for Digicert (geotrustglobalca) expiring in May 2022
• 3943c89: 8282044: [JVMCI] Export _sha3_implCompress, _md5_implCompress and aarch64::_has_negatives stubs to JVMCI compiler.
• 7ce75af: 8255266: Update Public Suffix List to 3c213aa
• cfbfd9b: 8282103: fix macosx-generic typo in ProblemList
• 413bef6: 8282049: AArch64: Use ZR for integer zero immediate volatile stores
• cf6984d: 8282086: Update jib profile to not set build to 0
• f5120b7: 8282056: Clean up com.sun.tools.javac.util.GraphUtils
• ... and 52 more: https://git.openjdk.java.net/jdk/compare/f82866bc79cbeeac23716fa6fadd4877f5d0a462...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TobiHartmann @eme64 Pushed as commit 4e0b81c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.