Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8282049: AArch64: Use ZR for integer zero immediate volatile stores #7515

Closed
wants to merge 3 commits into from

Conversation

dchuyko
Copy link
Member

@dchuyko dchuyko commented Feb 17, 2022

Rules and encodings for volatile stores of immediate zero byte, char, int, long and pointers were added in aarch64.ad. E.g. storeimmN0_volatile() and aarch64_enc_stlrw0(). They use stlr instructions with ZR similar to what is already done for non-volatile zero stores and str instructions.

So for example

mov x13, xzr
stlr x13, [x11]

turns into

stlr xzr [x11]

There's no direct effect in dedicated micro-benchmarks on N1 but 1 register and 1 instruction are saved.

Testing: jtreg tier1, tier2, applications/jcstress on bare metal Graviton 2.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8282049: AArch64: Use ZR for integer zero immediate volatile stores

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7515/head:pull/7515
$ git checkout pull/7515

Update a local copy of the PR:
$ git checkout pull/7515
$ git pull https://git.openjdk.java.net/jdk pull/7515/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7515

View PR using the GUI difftool:
$ git pr show -t 7515

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7515.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 17, 2022

👋 Welcome back dchuyko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 17, 2022

@dchuyko The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler label Feb 17, 2022
@dchuyko dchuyko changed the title Added rules for stlr zr, mem 8282049: AArch64: Use ZR for integer zero immediate volatile stores Feb 17, 2022
@openjdk openjdk bot added the rfr label Feb 17, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 17, 2022

Webrevs

adinn
adinn approved these changes Feb 17, 2022
Copy link
Contributor

@adinn adinn left a comment

Looks good.

@openjdk
Copy link

openjdk bot commented Feb 17, 2022

@dchuyko This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282049: AArch64: Use ZR for integer zero immediate volatile stores

Reviewed-by: adinn, phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 17, 2022
Copy link
Member

@phohensee phohensee left a comment

Lgtm.

@dchuyko
Copy link
Member Author

dchuyko commented Feb 18, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Feb 18, 2022

Going to push as commit 413bef6.
Since your change was applied there have been 7 commits pushed to the master branch:

  • cf6984d: 8282086: Update jib profile to not set build to 0
  • f5120b7: 8282056: Clean up com.sun.tools.javac.util.GraphUtils
  • e336504: 8280866: SuppressWarnings does not work properly in package-info and module-info
  • e8224f7: 8282089: [BACKOUT] Parallel: Refactor PSCardTable::scavenge_contents_parallel
  • 834d55c: 8277300: Issues with javadoc support for preview features
  • 138a171: 8281267: VM HeapDumper dumps array classes several times
  • 7bcca76: 8279068: IGV: Update to work with JDK 16 and 17

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Feb 18, 2022
@openjdk openjdk bot closed this Feb 18, 2022
@openjdk openjdk bot removed ready rfr labels Feb 18, 2022
@openjdk
Copy link

openjdk bot commented Feb 18, 2022

@dchuyko Pushed as commit 413bef6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler integrated
3 participants