Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8282017 : sun/net/www/protocol/https/HttpsURLConnection/B6216082.java fails with "SocketException: Unexpected end of file from server" #7519

Closed
wants to merge 1 commit into from

Conversation

mahendrachhipa
Copy link
Member

@mahendrachhipa mahendrachhipa commented Feb 17, 2022

Updated TunnelProxy to avoid twice read of Request line.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8282017: sun/net/www/protocol/https/HttpsURLConnection/B6216082.java fails with "SocketException: Unexpected end of file from server"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7519/head:pull/7519
$ git checkout pull/7519

Update a local copy of the PR:
$ git checkout pull/7519
$ git pull https://git.openjdk.java.net/jdk pull/7519/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7519

View PR using the GUI difftool:
$ git pr show -t 7519

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7519.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 17, 2022

👋 Welcome back mahendrachhipa! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 17, 2022
@openjdk
Copy link

openjdk bot commented Feb 17, 2022

@mahendrachhipa The following labels will be automatically applied to this pull request:

  • net
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security security-dev@openjdk.org net net-dev@openjdk.org labels Feb 17, 2022
@mahendrachhipa mahendrachhipa changed the title JDK-8282017 : sun/net/www/protocol/https/HttpsURLConnection/B6216082.… JDK-8282017 : sun/net/www/protocol/https/HttpsURLConnection/B6216082.java fails with "SocketException: Unexpected end of file from server" Feb 17, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 17, 2022

Webrevs

Copy link
Member

@dfuch dfuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me Mahendra. I will withdraw my own PR. Just make sure to run the whole of tier2 :-)

@openjdk
Copy link

openjdk bot commented Feb 17, 2022

@mahendrachhipa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282017: sun/net/www/protocol/https/HttpsURLConnection/B6216082.java fails with "SocketException: Unexpected end of file from server"

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • a6f8a38: 8281000: ClassLoader::registerAsParallelCapable throws NPE if caller is null
  • 4c7f8b4: 8268250: Class.arrayType() for a 255-d array throws undocumented IllegalArgumentException

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dfuch) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 17, 2022
@mahendrachhipa
Copy link
Member Author

mahendrachhipa commented Feb 17, 2022


@mahendrachhipa
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 17, 2022
@openjdk
Copy link

openjdk bot commented Feb 17, 2022

@mahendrachhipa
Your change (at version 46cd81f) is now ready to be sponsored by a Committer.

@dfuch
Copy link
Member

dfuch commented Feb 17, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 17, 2022

Going to push as commit cd9a3cf.
Since your change was applied there have been 2 commits pushed to the master branch:

  • a6f8a38: 8281000: ClassLoader::registerAsParallelCapable throws NPE if caller is null
  • 4c7f8b4: 8268250: Class.arrayType() for a 255-d array throws undocumented IllegalArgumentException

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 17, 2022
@openjdk openjdk bot closed this Feb 17, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 17, 2022
@openjdk
Copy link

openjdk bot commented Feb 17, 2022

@dfuch @mahendrachhipa Pushed as commit cd9a3cf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net net-dev@openjdk.org security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants