Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276686: Malformed Javadoc inline tags in JDK source in /java/util/regex/Pattern.java #7521

Closed
wants to merge 1 commit into from

Conversation

igraves
Copy link
Member

@igraves igraves commented Feb 17, 2022

Adding a missing period per this doc bug.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8276686: Malformed Javadoc inline tags in JDK source in /java/util/regex/Pattern.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7521/head:pull/7521
$ git checkout pull/7521

Update a local copy of the PR:
$ git checkout pull/7521
$ git pull https://git.openjdk.java.net/jdk pull/7521/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7521

View PR using the GUI difftool:
$ git pr show -t 7521

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7521.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 17, 2022

👋 Welcome back igraves! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 17, 2022
@openjdk
Copy link

openjdk bot commented Feb 17, 2022

@igraves The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Feb 17, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 17, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 17, 2022

@igraves This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276686: Malformed Javadoc inline tags in JDK source in /java/util/regex/Pattern.java

Reviewed-by: iris, bpb, lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 17, 2022
@igraves
Copy link
Member Author

igraves commented Feb 22, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Feb 22, 2022

Going to push as commit 41355e2.
Since your change was applied there have been 36 commits pushed to the master branch:

  • 022d807: 8271008: appcds/*/MethodHandlesAsCollectorTest.java tests time out because of excessive GC (CodeCache GC Threshold) in loom
  • ab6d8e6: 8260328: Drop redundant CSS properties from java.desktop HTML files
  • b95310b: 8282220: contentType should not be a PKCS7's member
  • bc43320: 8281543: Remove unused code/headerfile dtraceAttacher.hpp
  • f953952: 8281745: Create a regression test for JDK-4514331
  • e0b4962: 8282190: Typo in javadoc of java.time.format.DateTimeFormatter#getDecimalStyle
  • e1c98bd: 8281523: Accessibility: Conversion from string literal loses const qualifier
  • cc7cf81: 8280861: Robot color picker broken on Linux with scaling above 100%
  • d7a706a: 8253757: Add LLVM-based backend for hsdis
  • bdae1d8: 8282147: [TESTBUG] waitForIdle after creating frame in JSpinnerMouseAndKeyPressTest.java
  • ... and 26 more: https://git.openjdk.java.net/jdk/compare/cd9a3cf05b2c200709103e2e8596414a62a1c441...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 22, 2022
@openjdk openjdk bot closed this Feb 22, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 22, 2022
@openjdk
Copy link

openjdk bot commented Feb 22, 2022

@igraves Pushed as commit 41355e2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants