Skip to content

Conversation

@wangweij
Copy link
Contributor

@wangweij wangweij commented Feb 17, 2022

Updating to a recent release of PSL.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7526/head:pull/7526
$ git checkout pull/7526

Update a local copy of the PR:
$ git checkout pull/7526
$ git pull https://git.openjdk.java.net/jdk pull/7526/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7526

View PR using the GUI difftool:
$ git pr show -t 7526

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7526.diff

8255266: 2021-11-27 public suffix list update v 3c213aa
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 17, 2022

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 17, 2022
@openjdk
Copy link

openjdk bot commented Feb 17, 2022

@wangweij The following labels will be automatically applied to this pull request:

  • build
  • core-libs
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security security-dev@openjdk.org build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Feb 17, 2022
@wangweij
Copy link
Contributor Author

/label remove build core-libs

@openjdk openjdk bot removed build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Feb 17, 2022
@openjdk
Copy link

openjdk bot commented Feb 17, 2022

@wangweij
The build label was successfully removed.

The core-libs label was successfully removed.

@mlbridge
Copy link

mlbridge bot commented Feb 17, 2022

Webrevs

@wangweij wangweij changed the title 8255266: 2021-11-27 public suffix list update v 3c213aa 8255266: Update Public Suffix List to 3c213aa Feb 18, 2022
@openjdk
Copy link

openjdk bot commented Feb 18, 2022

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255266: Update Public Suffix List to 3c213aa

Reviewed-by: xuelei

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • f5120b7: 8282056: Clean up com.sun.tools.javac.util.GraphUtils
  • e336504: 8280866: SuppressWarnings does not work properly in package-info and module-info
  • e8224f7: 8282089: [BACKOUT] Parallel: Refactor PSCardTable::scavenge_contents_parallel
  • 834d55c: 8277300: Issues with javadoc support for preview features
  • 138a171: 8281267: VM HeapDumper dumps array classes several times
  • 7bcca76: 8279068: IGV: Update to work with JDK 16 and 17
  • c928958: 8281936: compiler/arguments/TestCodeEntryAlignment.java fails on AVX512 machines
  • a22f422: 8037573: Typo in DefaultTreeModel docs: askAllowsChildren instead of asksAllowsChildren

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 18, 2022
@wangweij
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 18, 2022

Going to push as commit 7ce75af.
Since your change was applied there have been 11 commits pushed to the master branch:

  • cfbfd9b: 8282103: fix macosx-generic typo in ProblemList
  • 413bef6: 8282049: AArch64: Use ZR for integer zero immediate volatile stores
  • cf6984d: 8282086: Update jib profile to not set build to 0
  • f5120b7: 8282056: Clean up com.sun.tools.javac.util.GraphUtils
  • e336504: 8280866: SuppressWarnings does not work properly in package-info and module-info
  • e8224f7: 8282089: [BACKOUT] Parallel: Refactor PSCardTable::scavenge_contents_parallel
  • 834d55c: 8277300: Issues with javadoc support for preview features
  • 138a171: 8281267: VM HeapDumper dumps array classes several times
  • 7bcca76: 8279068: IGV: Update to work with JDK 16 and 17
  • c928958: 8281936: compiler/arguments/TestCodeEntryAlignment.java fails on AVX512 machines
  • ... and 1 more: https://git.openjdk.java.net/jdk/compare/fdce35f3a1c12a64238d0c76c02451a25b0b4abb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 18, 2022
@openjdk openjdk bot closed this Feb 18, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 18, 2022
@openjdk
Copy link

openjdk bot commented Feb 18, 2022

@wangweij Pushed as commit 7ce75af.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@wangweij wangweij deleted the 8255266 branch March 7, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants