Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8282085: The REGISTER_DEFINITION macro is useless after JDK-8269122 #7528

Closed
wants to merge 1 commit into from

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Feb 18, 2022

After JDK-8269122 (4d2412e), REGISTER_DEFINITION is empty and should be removed together with the files using it.

Thanks,
Tobias


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8282085: The REGISTER_DEFINITION macro is useless after JDK-8269122

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7528/head:pull/7528
$ git checkout pull/7528

Update a local copy of the PR:
$ git checkout pull/7528
$ git pull https://git.openjdk.java.net/jdk pull/7528/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7528

View PR using the GUI difftool:
$ git pr show -t 7528

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7528.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 18, 2022

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 18, 2022
@openjdk
Copy link

openjdk bot commented Feb 18, 2022

@TobiHartmann The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Feb 18, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 18, 2022

Webrevs

Copy link
Member

@DamonFool DamonFool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk
Copy link

openjdk bot commented Feb 18, 2022

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282085: The REGISTER_DEFINITION macro is useless after JDK-8269122

Reviewed-by: jiefu, chagedorn, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 7ce75af: 8255266: Update Public Suffix List to 3c213aa
  • cfbfd9b: 8282103: fix macosx-generic typo in ProblemList
  • 413bef6: 8282049: AArch64: Use ZR for integer zero immediate volatile stores
  • cf6984d: 8282086: Update jib profile to not set build to 0
  • f5120b7: 8282056: Clean up com.sun.tools.javac.util.GraphUtils
  • e336504: 8280866: SuppressWarnings does not work properly in package-info and module-info
  • e8224f7: 8282089: [BACKOUT] Parallel: Refactor PSCardTable::scavenge_contents_parallel
  • 834d55c: 8277300: Issues with javadoc support for preview features
  • 138a171: 8281267: VM HeapDumper dumps array classes several times
  • 7bcca76: 8279068: IGV: Update to work with JDK 16 and 17

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 18, 2022
@TobiHartmann
Copy link
Member Author

Thanks for the review!

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@TobiHartmann
Copy link
Member Author

Thanks Christian and Vladimir.

@TobiHartmann
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 21, 2022

Going to push as commit 8563d86.
Since your change was applied there have been 14 commits pushed to the master branch:

  • d28b048: 8281815: x86: Use short jumps in TIG::generate_slow_signature_handler
  • d7f31d0: 8282077: PKCS11 provider C_sign() impl should handle CKR_BUFFER_TOO_SMALL error
  • d3749de: 8277488: Add expiry exception for Digicert (geotrustglobalca) expiring in May 2022
  • 3943c89: 8282044: [JVMCI] Export _sha3_implCompress, _md5_implCompress and aarch64::_has_negatives stubs to JVMCI compiler.
  • 7ce75af: 8255266: Update Public Suffix List to 3c213aa
  • cfbfd9b: 8282103: fix macosx-generic typo in ProblemList
  • 413bef6: 8282049: AArch64: Use ZR for integer zero immediate volatile stores
  • cf6984d: 8282086: Update jib profile to not set build to 0
  • f5120b7: 8282056: Clean up com.sun.tools.javac.util.GraphUtils
  • e336504: 8280866: SuppressWarnings does not work properly in package-info and module-info
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/c9289583eb6919ced3b4115cf981180f6a957fbf...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 21, 2022
@openjdk openjdk bot closed this Feb 21, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 21, 2022
@openjdk
Copy link

openjdk bot commented Feb 21, 2022

@TobiHartmann Pushed as commit 8563d86.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants