-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8282085: The REGISTER_DEFINITION macro is useless after JDK-8269122 #7528
Conversation
👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into |
@TobiHartmann The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@TobiHartmann This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Thanks for the review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks Christian and Vladimir. |
/integrate |
Going to push as commit 8563d86.
Your commit was automatically rebased without conflicts. |
@TobiHartmann Pushed as commit 8563d86. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
After JDK-8269122 (4d2412e),
REGISTER_DEFINITION
is empty and should be removed together with the files using it.Thanks,
Tobias
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7528/head:pull/7528
$ git checkout pull/7528
Update a local copy of the PR:
$ git checkout pull/7528
$ git pull https://git.openjdk.java.net/jdk pull/7528/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7528
View PR using the GUI difftool:
$ git pr show -t 7528
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7528.diff