Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7110890: reg test TranslucentShapedFrameTest fails to create non-opaque frame #753

Closed
wants to merge 1 commit into from

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Oct 19, 2020

This manual test was created during the development phase of jdk7 when it was possible to create translucent/non-opaque decorated frames. That was changed by the https://bugs.openjdk.java.net/browse/JDK-6993784

The test allows creating and changing on the fly: translucent/shaped/transparent frames all such windows should be undecorated.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build ✔️ (5/5 passed) (2/2 running) ✔️ (2/2 passed)
Test (tier1) (6/9 running) (9/9 running)

Issue

  • JDK-7110890: reg test TranslucentShapedFrameTest fails to create non-opaque frame

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/753/head:pull/753
$ git checkout pull/753

serb
frame.setUndecorated(true);
}

frame.setUndecorated(true);

This comment has been minimized.

@mrserb

mrserb Oct 19, 2020
Author Member

This is the main fix, always use undecorated frames.

@@ -277,6 +281,9 @@ private void createFrameBtnActionPerformed(java.awt.event.ActionEvent evt) {//GE
useSwingCb.isSelected(), shapedCb.isSelected(),
(transl < 100), nonOpaqueChb.isSelected(),
(float)transl/100f);
createFrameBtn.setEnabled(false);
disposeFrameBtn.setEnabled(true);
useSwingCb.setEnabled(false);

This comment has been minimized.

@mrserb

mrserb Oct 19, 2020
Author Member

Just a usability cleanup - disable some buttons that are noop in some states.

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 19, 2020

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2020

@mrserb The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt label Oct 19, 2020
@mrserb mrserb marked this pull request as ready for review Oct 19, 2020
@openjdk openjdk bot added the rfr label Oct 19, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 19, 2020

Webrevs

@prrace
prrace approved these changes Oct 19, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2020

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7110890: reg test TranslucentShapedFrameTest fails to create non-opaque frame

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 19, 2020
@mrserb
Copy link
Member Author

@mrserb mrserb commented Oct 19, 2020

/integrate

@openjdk openjdk bot closed this Oct 19, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 19, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2020

@mrserb Since your change was applied there has been 1 commit pushed to the master branch:

  • bf19581: 8255016: ConstantDescs.FALSE claims it represents TRUE

Your commit was automatically rebased without conflicts.

Pushed as commit 6e8835c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the mrserb:JDK-7110890 branch Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants