New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7110890: reg test TranslucentShapedFrameTest fails to create non-opaque frame #753
Conversation
frame.setUndecorated(true); | ||
} | ||
|
||
frame.setUndecorated(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the main fix, always use undecorated frames.
@@ -277,6 +281,9 @@ private void createFrameBtnActionPerformed(java.awt.event.ActionEvent evt) {//GE | |||
useSwingCb.isSelected(), shapedCb.isSelected(), | |||
(transl < 100), nonOpaqueChb.isSelected(), | |||
(float)transl/100f); | |||
createFrameBtn.setEnabled(false); | |||
disposeFrameBtn.setEnabled(true); | |||
useSwingCb.setEnabled(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a usability cleanup - disable some buttons that are noop in some states.
👋 Welcome back serb! A progress list of the required criteria for merging this PR into |
@mrserb This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@mrserb Since your change was applied there has been 1 commit pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 6e8835c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This manual test was created during the development phase of jdk7 when it was possible to create translucent/non-opaque decorated frames. That was changed by the https://bugs.openjdk.java.net/browse/JDK-6993784
The test allows creating and changing on the fly: translucent/shaped/transparent frames all such windows should be undecorated.
Progress
Testing
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/753/head:pull/753
$ git checkout pull/753