Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8260328: Drop redundant CSS properties from java.desktop HTML files #7546

Closed
wants to merge 2 commits into from

Conversation

aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Feb 20, 2022

Drop redundant text-align: left from <table> elements, which don't affect the table alignment. Then drop text-align: center from <th> elements which counter-act the align set on the

`.

Also drop vertical-align: top from table cells and declare this style globally. This makes the properties and values be rendered at the top of the table cell in cases where the description wraps to multiple lines.

Visually, the updated tables look nearly the same way as before. I left out applying top alignment for <thead> elements: the headers are center-aligned. You can see this in tables for JOptionPane, JProgressBar and other components which have long descriptions so that Expected Type and Default Value are wrapped to two lines.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8260328: Drop redundant CSS properties from java.desktop HTML files

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7546/head:pull/7546
$ git checkout pull/7546

Update a local copy of the PR:
$ git checkout pull/7546
$ git pull https://git.openjdk.java.net/jdk pull/7546/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7546

View PR using the GUI difftool:
$ git pr show -t 7546

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7546.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 20, 2022

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 20, 2022
@openjdk
Copy link

openjdk bot commented Feb 20, 2022

@aivanov-jdk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Feb 20, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 20, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 22, 2022

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260328: Drop redundant CSS properties from java.desktop HTML files

Reviewed-by: serb, dmarkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • b95310b: 8282220: contentType should not be a PKCS7's member
  • bc43320: 8281543: Remove unused code/headerfile dtraceAttacher.hpp
  • f953952: 8281745: Create a regression test for JDK-4514331
  • e0b4962: 8282190: Typo in javadoc of java.time.format.DateTimeFormatter#getDecimalStyle
  • e1c98bd: 8281523: Accessibility: Conversion from string literal loses const qualifier
  • cc7cf81: 8280861: Robot color picker broken on Linux with scaling above 100%
  • d7a706a: 8253757: Add LLVM-based backend for hsdis
  • bdae1d8: 8282147: [TESTBUG] waitForIdle after creating frame in JSpinnerMouseAndKeyPressTest.java
  • 51f4420: 8282130: (bf) Remove unused ARRAY_BASE_OFFSET, ARRAY_INDEX_SCALE from read-only Heap Buffers
  • 34aae32: 8282166: JDK-8282158 changed ECParameters' package by accident
  • ... and 5 more: https://git.openjdk.java.net/jdk/compare/d7f31d0d53bfec627edc83ceb75fc6202891e186...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 22, 2022
@aivanov-jdk
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 22, 2022

Going to push as commit ab6d8e6.
Since your change was applied there have been 15 commits pushed to the master branch:

  • b95310b: 8282220: contentType should not be a PKCS7's member
  • bc43320: 8281543: Remove unused code/headerfile dtraceAttacher.hpp
  • f953952: 8281745: Create a regression test for JDK-4514331
  • e0b4962: 8282190: Typo in javadoc of java.time.format.DateTimeFormatter#getDecimalStyle
  • e1c98bd: 8281523: Accessibility: Conversion from string literal loses const qualifier
  • cc7cf81: 8280861: Robot color picker broken on Linux with scaling above 100%
  • d7a706a: 8253757: Add LLVM-based backend for hsdis
  • bdae1d8: 8282147: [TESTBUG] waitForIdle after creating frame in JSpinnerMouseAndKeyPressTest.java
  • 51f4420: 8282130: (bf) Remove unused ARRAY_BASE_OFFSET, ARRAY_INDEX_SCALE from read-only Heap Buffers
  • 34aae32: 8282166: JDK-8282158 changed ECParameters' package by accident
  • ... and 5 more: https://git.openjdk.java.net/jdk/compare/d7f31d0d53bfec627edc83ceb75fc6202891e186...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 22, 2022
@openjdk openjdk bot closed this Feb 22, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 22, 2022
@openjdk
Copy link

openjdk bot commented Feb 22, 2022

@aivanov-jdk Pushed as commit ab6d8e6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@aivanov-jdk aivanov-jdk deleted the 8260328-dropCSS branch May 24, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants