-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8260328: Drop redundant CSS properties from java.desktop HTML files #7546
Conversation
👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into |
@aivanov-jdk The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@aivanov-jdk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 15 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit ab6d8e6.
Your commit was automatically rebased without conflicts. |
@aivanov-jdk Pushed as commit ab6d8e6. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Drop redundant
`.text-align: left
from<table>
elements, which don't affect the table alignment. Then droptext-align: center
from<th> elements which counter-act the align set on the
Also drop
vertical-align: top
from table cells and declare this style globally. This makes the properties and values be rendered at the top of the table cell in cases where the description wraps to multiple lines.Visually, the updated tables look nearly the same way as before. I left out applying top alignment for
<thead>
elements: the headers are center-aligned. You can see this in tables forJOptionPane
,JProgressBar
and other components which have long descriptions so that Expected Type and Default Value are wrapped to two lines.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7546/head:pull/7546
$ git checkout pull/7546
Update a local copy of the PR:
$ git checkout pull/7546
$ git pull https://git.openjdk.java.net/jdk pull/7546/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7546
View PR using the GUI difftool:
$ git pr show -t 7546
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7546.diff