Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8282150: Drop redundant <br> elements from tables in java.desktop HTML files #7547

Closed
wants to merge 4 commits into from

Conversation

aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Feb 20, 2022

Drops the redundant <br> elements from tables and lists in java.desktop HTML files.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8282150: Drop redundant
    elements from tables in java.desktop HTML files

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7547/head:pull/7547
$ git checkout pull/7547

Update a local copy of the PR:
$ git checkout pull/7547
$ git pull https://git.openjdk.java.net/jdk pull/7547/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7547

View PR using the GUI difftool:
$ git pr show -t 7547

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7547.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 20, 2022

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into pr/7546 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 20, 2022
@openjdk
Copy link

openjdk bot commented Feb 20, 2022

@aivanov-jdk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Feb 20, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 20, 2022

Webrevs

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/7546 to master February 22, 2022 13:23
@openjdk-notifier
Copy link

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout 8260328-dropCSS
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

openjdk bot commented Feb 23, 2022

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282150: Drop redundant <br> elements from tables in java.desktop HTML files

Reviewed-by: jdv, dmarkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • 9332071: 8282194: C1: Missing side effects of dynamic constant linkage
  • ecd85e6: 8282231: x86-32: runtime call to SharedRuntime::ldiv corrupts registers
  • 378fa50: 8281962: Avoid unnecessary native calls in InflaterInputStream
  • e1060be: 8281615: Deadlock caused by jdwp agent
  • 6f882de: 8280964: [Linux aarch64] : drawImage dithers TYPE_BYTE_INDEXED images incorrectly
  • 2557ef8: 8282276: Problem list failing two Robot Screen Capture tests
  • 6445ee4: 5041655: (ch) FileLock: negative param and overflow issues
  • 7feabee: 8261407: ReflectionFactory.checkInitted() is not thread-safe
  • 58e1882: 8282042: [testbug] FileEncodingTest.java depends on default encoding
  • 3cb3867: 8281315: Unicode, (?i) flag and backreference throwing IndexOutOfBounds Exception
  • ... and 3 more: https://git.openjdk.java.net/jdk/compare/022d80707c346f4b82ac1eb53e77c634769631e9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 23, 2022
@aivanov-jdk
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 1, 2022

Going to push as commit b86a8c0.
Since your change was applied there have been 80 commits pushed to the master branch:

  • 941e97c: 8281738: Create a regression test for checking the 'Space' key activation of focused Button
  • 8fec7b8: 8281548: Add escape analysis tracing flag
  • b03d66c: 8282452: Use of Preview API in preview methods should not trigger preview warning for the enclosing class
  • 76398c8: 8279573: compiler/codecache/CodeCacheFullCountTest.java fails with "RuntimeException: the value of full_count is wrong."
  • 31b61f9: 8282311: Fix a typo in javax.lang.model.type.NullType
  • 2c5d266: 8282045: When loop strip mining fails, safepoints are removed from loop anyway
  • 341c8bd: 8267834: Refactor G1CardSetAllocator and BufferNode::Allocator to use a common base class
  • fcce24c: 8281811: assert(_base == Tuple) failed: Not a Tuple after JDK-8280799
  • a95edee: 8281472: JVM options processing silently truncates large illegal options values
  • 44d599a: 8227369: pd_disjoint_words_atomic() needs to be atomic
  • ... and 70 more: https://git.openjdk.java.net/jdk/compare/022d80707c346f4b82ac1eb53e77c634769631e9...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 1, 2022
@openjdk openjdk bot closed this Mar 1, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 1, 2022
@openjdk
Copy link

openjdk bot commented Mar 1, 2022

@aivanov-jdk Pushed as commit b86a8c0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@aivanov-jdk aivanov-jdk deleted the 8282150-drop-br branch May 24, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants