8282094: [REDO] Parallel: Refactor PSCardTable::scavenge_contents_parallel

[albertnetymk]

Mostly the same as JDK-8280783, except one assertion is weakened.

assert(*dirty_r == clean_card || dirty_r >= clear_limit_r);

Test: tier1-6
I also tried to reproduce the failures in https://bugs.openjdk.java.net/browse/JDK-8282062, but to no avail.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8282094: [REDO] Parallel: Refactor PSCardTable::scavenge_contents_parallel

Reviewers

• Ivan Walulya (@walulyai - Reviewer)
• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7573/head:pull/7573
$ git checkout pull/7573

Update a local copy of the PR:
$ git checkout pull/7573
$ git pull https://git.openjdk.java.net/jdk pull/7573/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7573

View PR using the GUI difftool:
$ git pr show -t 7573

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7573.diff

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (9bb01400)

[walulyai]

Lgtm!

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282094: [REDO] Parallel: Refactor PSCardTable::scavenge_contents_parallel

Reviewed-by: iwalulya, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 91 new commits pushed to the master branch:

• d3022f8: 8282467: add extra diagnostics for JDK-8268184
• e4d9fc8: 8282023: PropertiesStoreTest and StoreReproducibilityTest jtreg failures due to en_CA locale
• c1a28aa: 8282392: [zero] Build broken on AArch64
• 7743266: 8281210: Add manpage changes for PAC-RET protection on Linux/AArch64
• 1f89acd: 8282464: Remove author tags from java.compiler
• 9d9618a: 8282462: Remove unnecessary use of @SuppressWarnings("preview")
• d983d10: 8275731: CDS archived enums objects are recreated at runtime
• c7cd148: 8282240: Add _name field to Method for NOT_PRODUCT only
• 59b3ecc: 8277976: Break up SEQUENCE in X509Certificate::getSubjectAlternativeNames and X509Certificate::getIssuerAlternativeNames in otherName
• 4e7fb41: 8282172: CompileBroker::log_metaspace_failure is called from non-Java/compiler threads
• ... and 81 more: https://git.openjdk.java.net/jdk/compare/e3365041bdef4dc09f3e5967124103e4364614fb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tschatzl]

Lgtm.

Fwiw, in redos it is typically a nice to have two commits if the actual change is minimal: the first one re-adding the original change, the second one the actual difference. That makes reviewing even easier. :)

[albertnetymk]

Fwiw, in redos it is typically a nice to have two commits if the actual change is minimal:

Got it; will do so next time.

Thanks for the review.

/integrate

[openjdk]

Going to push as commit 22b93a3.
Since your change was applied there have been 91 commits pushed to the master branch:

• d3022f8: 8282467: add extra diagnostics for JDK-8268184
• e4d9fc8: 8282023: PropertiesStoreTest and StoreReproducibilityTest jtreg failures due to en_CA locale
• c1a28aa: 8282392: [zero] Build broken on AArch64
• 7743266: 8281210: Add manpage changes for PAC-RET protection on Linux/AArch64
• 1f89acd: 8282464: Remove author tags from java.compiler
• 9d9618a: 8282462: Remove unnecessary use of @SuppressWarnings("preview")
• d983d10: 8275731: CDS archived enums objects are recreated at runtime
• c7cd148: 8282240: Add _name field to Method for NOT_PRODUCT only
• 59b3ecc: 8277976: Break up SEQUENCE in X509Certificate::getSubjectAlternativeNames and X509Certificate::getIssuerAlternativeNames in otherName
• 4e7fb41: 8282172: CompileBroker::log_metaspace_failure is called from non-Java/compiler threads
• ... and 81 more: https://git.openjdk.java.net/jdk/compare/e3365041bdef4dc09f3e5967124103e4364614fb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit 22b93a3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.