Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6218162: DefaultTableColumnModel.getColumn() method should mention ArrayIndexOutOfBoundsException #7587

Closed
wants to merge 5 commits into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Feb 23, 2022

If invalid ie 0 or > getColumnCount() index is passed to DefaultTableColumnModel.getColumn() then it returns AIOBE in current implementation which should be documented in the spec. Fixed the spec to mention the exception.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed
  • Change requires a CSR request to be approved

Issues

  • JDK-6218162: DefaultTableColumnModel.getColumn() method should mention ArrayIndexOutOfBoundsException
  • JDK-8282378: DefaultTableColumnModel.getColumn() method should mention ArrayIndexOutOfBoundsException (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7587/head:pull/7587
$ git checkout pull/7587

Update a local copy of the PR:
$ git checkout pull/7587
$ git pull https://git.openjdk.java.net/jdk pull/7587/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7587

View PR using the GUI difftool:
$ git pr show -t 7587

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7587.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 23, 2022

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 23, 2022
@openjdk
Copy link

openjdk bot commented Feb 23, 2022

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Feb 23, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 23, 2022

Webrevs

Copy link
Member

@aivanov-jdk aivanov-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change probably requires a CSR.

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Feb 25, 2022
Copy link
Member

@aivanov-jdk aivanov-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the copyright year shall be updated too.

Other than that, it looks good.

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Feb 25, 2022
@openjdk
Copy link

openjdk bot commented Feb 25, 2022

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6218162: DefaultTableColumnModel.getColumn() method should mention ArrayIndexOutOfBoundsException

Reviewed-by: aivanov, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 145 new commits pushed to the master branch:

  • b0028a4: 8272853: improve JavadocTester.runTests
  • e07fd39: 8281181: Do not use CPU Shares to compute active processor count
  • 9c817d3: 8015854: [macosx] JButton's HTML ImageView adding unwanted padding
  • 733c790: 8282081: java.time.DateTimeFormatter: wrong definition of symbol F
  • f9f9c0a: 8252769: Warn in configure if git config autocrlf has invalid value
  • 603050b: 8282661: [BACKOUT] ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y)
  • 5247153: 8282615: G1: Fix some includes
  • a584c90: 8282573: ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y)
  • d5e8e52: 8282532: Allow explicitly setting build platform alongside --openjdk-target
  • b383780: 8282343: Create a regression test for JDK-4518432
  • ... and 135 more: https://git.openjdk.java.net/jdk/compare/f5120b764c6f84776e7ea335d7ff59b16f6496b0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 25, 2022
@prsadhuk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 10, 2022

Going to push as commit 6a3a7b9.
Since your change was applied there have been 192 commits pushed to the master branch:

  • 5b78a82: 7017094: ParsedSynthStyle: parameter name "direction" should be changed to "tabIndex"
  • 8aba4de: 8249592: Robot.mouseMove moves cursor to incorrect location when display scale varies and Java runs in DPI Unaware mode
  • ff76620: 8282641: Make jdb "threadgroup" command with no args reset the current threadgroup back to the default
  • 70318e1: 8282884: Provide OID aliases for MD2, MD5, and OAEP
  • 6d8d156: 8280494: (D)TLS signature schemes
  • 5df2a05: 8282628: Potential memory leak in sun.font.FontConfigManager.getFontConfig()
  • d07f7c7: 8282665: [REDO] ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y)
  • 31ad80a: 8280902: ResourceBundle::getBundle may throw NPE when invoked by JNI code with no caller frame
  • 12693a6: 8282432: Optimize masked "test" Vector API with predicate feature
  • 4924513: 8265263: AArch64: Combine vneg with right shift count
  • ... and 182 more: https://git.openjdk.java.net/jdk/compare/f5120b764c6f84776e7ea335d7ff59b16f6496b0...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 10, 2022
@openjdk openjdk bot closed this Mar 10, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 10, 2022
@openjdk
Copy link

openjdk bot commented Mar 10, 2022

@prsadhuk Pushed as commit 6a3a7b9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-6218162 branch March 10, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants