-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6218162: DefaultTableColumnModel.getColumn() method should mention ArrayIndexOutOfBoundsException #7587
Conversation
…rayIndexOutOfBoundsException
👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change probably requires a CSR.
src/java.desktop/share/classes/javax/swing/table/DefaultTableColumnModel.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the copyright year shall be updated too.
Other than that, it looks good.
@prsadhuk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 145 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
src/java.desktop/share/classes/javax/swing/table/DefaultTableColumnModel.java
Show resolved
Hide resolved
/integrate |
Going to push as commit 6a3a7b9.
Your commit was automatically rebased without conflicts. |
If invalid ie 0 or > getColumnCount() index is passed to DefaultTableColumnModel.getColumn() then it returns AIOBE in current implementation which should be documented in the spec. Fixed the spec to mention the exception.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7587/head:pull/7587
$ git checkout pull/7587
Update a local copy of the PR:
$ git checkout pull/7587
$ git pull https://git.openjdk.java.net/jdk pull/7587/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7587
View PR using the GUI difftool:
$ git pr show -t 7587
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7587.diff