Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8282320: Remove case conversion for debugging log in SSLCipher #7600

Closed
wants to merge 1 commit into from

Conversation

XueleiFan
Copy link
Member

@XueleiFan XueleiFan commented Feb 23, 2022

String.toUpperCase() is used in SSLCipher.java for debugging logging, which is not necessary. See also comment in this PR.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8282320: Remove case conversion for debugging log in SSLCipher

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7600/head:pull/7600
$ git checkout pull/7600

Update a local copy of the PR:
$ git checkout pull/7600
$ git pull https://git.openjdk.java.net/jdk pull/7600/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7600

View PR using the GUI difftool:
$ git pr show -t 7600

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7600.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 23, 2022

👋 Welcome back xuelei! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 23, 2022
@openjdk
Copy link

openjdk bot commented Feb 23, 2022

@XueleiFan The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security label Feb 23, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 23, 2022

Webrevs

@XueleiFan
Copy link
Member Author

XueleiFan commented Mar 1, 2022

ping ...

@openjdk
Copy link

openjdk bot commented Mar 1, 2022

@XueleiFan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282320: Remove case conversion for debugging log in SSLCipher

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 57 new commits pushed to the master branch:

  • b03d66c: 8282452: Use of Preview API in preview methods should not trigger preview warning for the enclosing class
  • 76398c8: 8279573: compiler/codecache/CodeCacheFullCountTest.java fails with "RuntimeException: the value of full_count is wrong."
  • 31b61f9: 8282311: Fix a typo in javax.lang.model.type.NullType
  • 2c5d266: 8282045: When loop strip mining fails, safepoints are removed from loop anyway
  • 341c8bd: 8267834: Refactor G1CardSetAllocator and BufferNode::Allocator to use a common base class
  • fcce24c: 8281811: assert(_base == Tuple) failed: Not a Tuple after JDK-8280799
  • a95edee: 8281472: JVM options processing silently truncates large illegal options values
  • 44d599a: 8227369: pd_disjoint_words_atomic() needs to be atomic
  • eff396f: 8280713: Related to comment inheritance jdk.javadoc cleanup and refactoring
  • 369291b: 8282444: Module finder incorrectly assumes default file system path-separator character
  • ... and 47 more: https://git.openjdk.java.net/jdk/compare/7dc7184c10fc8f7a02113056da979a9846a14cd4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 1, 2022
@XueleiFan
Copy link
Member Author

XueleiFan commented Mar 1, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Mar 1, 2022

Going to push as commit eac8021.
Since your change was applied there have been 60 commits pushed to the master branch:

  • b86a8c0: 8282150: Drop redundant
    elements from tables in java.desktop HTML files
  • 941e97c: 8281738: Create a regression test for checking the 'Space' key activation of focused Button
  • 8fec7b8: 8281548: Add escape analysis tracing flag
  • b03d66c: 8282452: Use of Preview API in preview methods should not trigger preview warning for the enclosing class
  • 76398c8: 8279573: compiler/codecache/CodeCacheFullCountTest.java fails with "RuntimeException: the value of full_count is wrong."
  • 31b61f9: 8282311: Fix a typo in javax.lang.model.type.NullType
  • 2c5d266: 8282045: When loop strip mining fails, safepoints are removed from loop anyway
  • 341c8bd: 8267834: Refactor G1CardSetAllocator and BufferNode::Allocator to use a common base class
  • fcce24c: 8281811: assert(_base == Tuple) failed: Not a Tuple after JDK-8280799
  • a95edee: 8281472: JVM options processing silently truncates large illegal options values
  • ... and 50 more: https://git.openjdk.java.net/jdk/compare/7dc7184c10fc8f7a02113056da979a9846a14cd4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Mar 1, 2022
@openjdk openjdk bot closed this Mar 1, 2022
@openjdk openjdk bot removed ready rfr labels Mar 1, 2022
@openjdk
Copy link

openjdk bot commented Mar 1, 2022

@XueleiFan Pushed as commit eac8021.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@XueleiFan XueleiFan deleted the JDK-8282320 branch Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated security
2 participants