-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8255038: Adjust adapter_code_size to account for -Xlog:methodhandles in debug builds #761
Conversation
👋 Welcome back redestad! A progress list of the required criteria for merging this PR into |
@cl4es This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and trivial
@cl4es Your integration request cannot be fulfilled at this time, as the status check |
/integrate |
@cl4es Since your change was applied there have been 3 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 76fdd7f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
https://bugs.openjdk.java.net/browse/JDK-8254955 trimmed the space allocated for MethodHandleAdapterBlob, but my analysis failed to account for added trace code information being generated when running with -Xlog:methodhandles (on top of the extra tracing/debugging when running with -XX:+VerifyMethodHandles et.c.). This caused a failure in tier3 Windows ZGC tests.
Adjusting the debug size up a notch ensures we stay within bounds.
Testing: tier3
Progress
Testing
Failed test task
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/761/head:pull/761
$ git checkout pull/761