Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8282398: EndingDotHostname.java test fails because SSL cert expired #7626

Closed
wants to merge 3 commits into from
Closed

Conversation

rhalade
Copy link
Member

@rhalade rhalade commented Feb 25, 2022

Updated test certificates with 20 years of validity


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8282398: EndingDotHostname.java test fails because SSL cert expired

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7626/head:pull/7626
$ git checkout pull/7626

Update a local copy of the PR:
$ git checkout pull/7626
$ git pull https://git.openjdk.java.net/jdk pull/7626/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7626

View PR using the GUI difftool:
$ git pr show -t 7626

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7626.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 25, 2022

👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 25, 2022
@openjdk
Copy link

openjdk bot commented Feb 25, 2022

@rhalade The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security label Feb 25, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 25, 2022

Webrevs

Copy link
Member

@XueleiFan XueleiFan left a comment

Looks good to me. Thanks!

@openjdk
Copy link

openjdk bot commented Feb 26, 2022

@rhalade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282398: EndingDotHostname.java test fails because SSL cert expired

Reviewed-by: xuelei

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • c5c6058: 8282219: jdk/java/lang/ProcessBuilder/Basic.java fails on AIX
  • fb8bf81: 8279995: jpackage --add-launcher option should allow overriding description

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 26, 2022
@rhalade
Copy link
Member Author

rhalade commented Feb 26, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Feb 26, 2022

Going to push as commit afd4bcb.
Since your change was applied there have been 3 commits pushed to the master branch:

  • cf6d256: 8282153: JFR: Check for recording waste
  • c5c6058: 8282219: jdk/java/lang/ProcessBuilder/Basic.java fails on AIX
  • fb8bf81: 8279995: jpackage --add-launcher option should allow overriding description

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Feb 26, 2022
@openjdk openjdk bot closed this Feb 26, 2022
@openjdk openjdk bot removed ready rfr labels Feb 26, 2022
@openjdk
Copy link

openjdk bot commented Feb 26, 2022

@rhalade Pushed as commit afd4bcb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@rhalade rhalade deleted the 8065422 branch Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated security
2 participants