8267820: (fs) Files.copy should attempt to copy POSIX attributes when target file in custom file system

[bplb]

In java.nio.file.Files.copy() copy POSIX attributes even if the target is from a different file system provided both the source and target file systems support such attributes.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8267820: (fs) Files.copy should attempt to copy POSIX attributes when target file in custom file system

Reviewers

• Lance Andersen (@LanceAndersen - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7627/head:pull/7627
$ git checkout pull/7627

Update a local copy of the PR:
$ git checkout pull/7627
$ git pull https://git.openjdk.java.net/jdk pull/7627/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7627

View PR using the GUI difftool:
$ git pr show -t 7627

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7627.diff

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (5de82f28)
• 01: Full - Incremental (beaf1754)
• 00: Full (348c8867)

[LanceAndersen]

Looks good to me

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267820: (fs) Files.copy should attempt to copy POSIX attributes when target file in custom file system

Reviewed-by: lancea, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 262 new commits pushed to the master branch:

• e8a1ce0: 8280881: (fs) UnixNativeDispatcher.close0 may throw UnixException
• 1668c02: 8277922: Unable to click JCheckBox in JTable through Java Access Bridge
• 2674799: 8282878: Removed _JavaThread from PhaseTraceTime
• 7c8ea9f: 8282509: [exploded image] ResolvedClassTest fails with similar output
• 9c88c5b: 8282948: JDK-8274980 missed correct handling of MACOSX_BUNDLE_BUILD_VERSION
• 83d7718: 8282893: Remove MacroAssembler::push/pop_callee_saved_registers
• 6a3a7b9: 6218162: DefaultTableColumnModel.getColumn() method should mention ArrayIndexOutOfBoundsException
• 5b78a82: 7017094: ParsedSynthStyle: parameter name "direction" should be changed to "tabIndex"
• 8aba4de: 8249592: Robot.mouseMove moves cursor to incorrect location when display scale varies and Java runs in DPI Unaware mode
• ff76620: 8282641: Make jdb "threadgroup" command with no args reset the current threadgroup back to the default
• ... and 252 more: https://git.openjdk.java.net/jdk/compare/f07b8165231799383303e5c0755d07afd2feb7fd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[AlanBateman]

The change to CopyMoveHelper look okay. If you are doing another round of cleanup then one thing that could be improve is the naming. The parameters "source" and "target" but the variables switch to "src" and "dst" so a bit inconsistent.

[bplb]

Thanks, @AlanBateman and @LanceAndersen.

/integrate

[openjdk]

Going to push as commit fdce97d.
Since your change was applied there have been 262 commits pushed to the master branch:

• e8a1ce0: 8280881: (fs) UnixNativeDispatcher.close0 may throw UnixException
• 1668c02: 8277922: Unable to click JCheckBox in JTable through Java Access Bridge
• 2674799: 8282878: Removed _JavaThread from PhaseTraceTime
• 7c8ea9f: 8282509: [exploded image] ResolvedClassTest fails with similar output
• 9c88c5b: 8282948: JDK-8274980 missed correct handling of MACOSX_BUNDLE_BUILD_VERSION
• 83d7718: 8282893: Remove MacroAssembler::push/pop_callee_saved_registers
• 6a3a7b9: 6218162: DefaultTableColumnModel.getColumn() method should mention ArrayIndexOutOfBoundsException
• 5b78a82: 7017094: ParsedSynthStyle: parameter name "direction" should be changed to "tabIndex"
• 8aba4de: 8249592: Robot.mouseMove moves cursor to incorrect location when display scale varies and Java runs in DPI Unaware mode
• ff76620: 8282641: Make jdb "threadgroup" command with no args reset the current threadgroup back to the default
• ... and 252 more: https://git.openjdk.java.net/jdk/compare/f07b8165231799383303e5c0755d07afd2feb7fd...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb Pushed as commit fdce97d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.