Skip to content

8282422: JTable.print() failed with UnsupportedCharsetException on AIX ko_KR locale #7630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

takiguc
Copy link

@takiguc takiguc commented Feb 26, 2022

On AIX ko_KR locale, I could see following exception after JTable.print() was called

java.nio.charset.UnsupportedCharsetException: sun.font.X11KSC5601
        at java.base/java.nio.charset.Charset.forName(Charset.java:527)
        at java.desktop/sun.awt.FontConfiguration.getFontCharsetEncoder(FontConfiguration.java:964)
......

According to my investigation, sun.font.X11KSC5601 moved from sun.awt.motif.X11KSC5601.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8282422: JTable.print() failed with UnsupportedCharsetException on AIX ko_KR locale

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7630/head:pull/7630
$ git checkout pull/7630

Update a local copy of the PR:
$ git checkout pull/7630
$ git pull https://git.openjdk.java.net/jdk pull/7630/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7630

View PR using the GUI difftool:
$ git pr show -t 7630

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7630.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 26, 2022

👋 Welcome back itakiguchi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 26, 2022
@openjdk
Copy link

openjdk bot commented Feb 26, 2022

@takiguc The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Feb 26, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 26, 2022

Webrevs

Copy link
Contributor

@prrace prrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be safe enough since I think AIX may be the only platform left that needs this.

@openjdk
Copy link

openjdk bot commented Mar 4, 2022

@takiguc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282422: JTable.print() failed with UnsupportedCharsetException on AIX ko_KR locale

Reviewed-by: prr, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 235 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 4, 2022
@takiguc
Copy link
Author

takiguc commented Mar 11, 2022

May I have a second reviewer, please ?

@takiguc
Copy link
Author

takiguc commented Mar 21, 2022

Please give me your suggestion.
I need one more reviewer.

@takiguc
Copy link
Author

takiguc commented Mar 23, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Mar 23, 2022

Going to push as commit 6ea996c.
Since your change was applied there have been 236 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 23, 2022
@openjdk openjdk bot closed this Mar 23, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 23, 2022
@openjdk
Copy link

openjdk bot commented Mar 23, 2022

@takiguc Pushed as commit 6ea996c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants