-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8282422: JTable.print() failed with UnsupportedCharsetException on AIX ko_KR locale #7630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back itakiguchi! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be safe enough since I think AIX may be the only platform left that needs this.
@takiguc This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 235 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
May I have a second reviewer, please ? |
Please give me your suggestion. |
/integrate |
Going to push as commit 6ea996c.
Your commit was automatically rebased without conflicts. |
On AIX ko_KR locale, I could see following exception after JTable.print() was called
According to my investigation, sun.font.X11KSC5601 moved from sun.awt.motif.X11KSC5601.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7630/head:pull/7630
$ git checkout pull/7630
Update a local copy of the PR:
$ git checkout pull/7630
$ git pull https://git.openjdk.java.net/jdk pull/7630/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7630
View PR using the GUI difftool:
$ git pr show -t 7630
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7630.diff