Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8282464: Remove author tags from java.compiler #7639

wants to merge 2 commits into from


Copy link

@jddarcy jddarcy commented Feb 28, 2022

To align with current coding conventions, the @author tags in the java.compiler module should be removed. The tags have not been maintained and updated in many years. These tags date back to the addition of JSRs 199 and 269 in JDK 6.

The authors at the time for these files were generally some nonempty subset of Scott Seligman, Peter von der Ahé, Jon Gibbons, Scott Seligman, and myself. The tag information will remain in the history of course.

I'll update the copyright years on the files before any push.


  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed




Using git

Checkout this PR locally:
$ git fetch pull/7639/head:pull/7639
$ git checkout pull/7639

Update a local copy of the PR:
$ git checkout pull/7639
$ git pull pull/7639/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7639

View PR using the GUI difftool:
$ git pr show -t 7639

Using diff file

Download this PR as a diff file:

Copy link

bridgekeeper bot commented Feb 28, 2022

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 28, 2022
Copy link

openjdk bot commented Feb 28, 2022

@jddarcy The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler label Feb 28, 2022
Copy link

mlbridge bot commented Feb 28, 2022


Copy link

@jonathan-gibbons jonathan-gibbons left a comment

While the reference to coding conventions may be controversial in itself, I note that it is the case that SCM metadata provides a better way of tracking contributions, especially for all contributions since the code was open-sourced. For example, git shortlog.

I note an appearance by Martin B, and somewhat surprising, an appearance by Neal Gafter, who had left before the file with his name on had been written.

Copy link

openjdk bot commented Feb 28, 2022

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file for details.

After integration, the commit message for the final commit will be:

8282464: Remove author tags from java.compiler

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 28, 2022
Copy link
Member Author

jddarcy commented Feb 28, 2022


Copy link

openjdk bot commented Feb 28, 2022

Going to push as commit 1f89acd.

@openjdk openjdk bot added the integrated label Feb 28, 2022
@openjdk openjdk bot closed this Feb 28, 2022
@openjdk openjdk bot removed ready rfr labels Feb 28, 2022
Copy link

openjdk bot commented Feb 28, 2022

@jddarcy Pushed as commit 1f89acd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
compiler integrated
2 participants