Skip to content

8274788: Support archived heap objects in ParallelGC #7655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

calvinccheung
Copy link
Member

@calvinccheung calvinccheung commented Mar 2, 2022

With this change when the UseParallelGC is enabled, the CDS archived heap objects could be loaded
into the PSOldGen during VM bootstrap. This improves startup time since the module graph could be
loaded from the archive.

$ perf stat -r 40 -XX:+UseParallelGC -version

before: 0.069244290 seconds time elapsed            ( +-  0.49% )
after:    0.058555167 seconds time elapsed          ( +-  0.49% )

Passed CI tiers 1 - 4 tests.

Thanks @tschatzl for his help on GC changes.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274788: Support archived heap objects in ParallelGC

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7655/head:pull/7655
$ git checkout pull/7655

Update a local copy of the PR:
$ git checkout pull/7655
$ git pull https://git.openjdk.java.net/jdk pull/7655/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7655

View PR using the GUI difftool:
$ git pr show -t 7655

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7655.diff

@calvinccheung
Copy link
Member Author

/label add hotspot-runtime
/label add hotspot-gc

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 2, 2022

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Mar 2, 2022
@openjdk
Copy link

openjdk bot commented Mar 2, 2022

@calvinccheung
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Mar 2, 2022
@openjdk
Copy link

openjdk bot commented Mar 2, 2022

@calvinccheung
The hotspot-gc label was successfully added.

@calvinccheung calvinccheung marked this pull request as ready for review March 2, 2022 07:09
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 2, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 2, 2022

Webrevs

Copy link
Member

@iklam iklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CDS and test changes look good to me.

@@ -0,0 +1,128 @@
/*
* Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 2022

@openjdk
Copy link

openjdk bot commented Mar 2, 2022

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274788: Support archived heap objects in ParallelGC

Reviewed-by: iklam, ayang, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 51 new commits pushed to the master branch:

  • fc918a7: 8281234: The -protected option is not always checked in keytool and jarsigner
  • d80f697: 8282523: Fix 'hierachy' typo
  • f12200c: 8267796: vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java fails with NoClassDefFoundError
  • 12a822a: 8282381: Parallel: Remove unnecessary PCReferenceProcessor
  • ed3496e: 8282480: IGV: Use description instead of enum name for phases
  • fc52a21: 8282143: Objects.requireNonNull should be ForceInline
  • 732d891: 8282411: Add useful predicates to ElementKind
  • eac8021: 8282320: Remove case conversion for debugging log in SSLCipher
  • b86a8c0: 8282150: Drop redundant
    elements from tables in java.desktop HTML files
  • 941e97c: 8281738: Create a regression test for checking the 'Space' key activation of focused Button
  • ... and 41 more: https://git.openjdk.java.net/jdk/compare/b6843a162411b0fa32271592d8f3a6f241a54384...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 2, 2022
Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@calvinccheung
Copy link
Member Author

Thanks Ioi, Albert, Thomas for the review.
/integrate

@openjdk
Copy link

openjdk bot commented Mar 2, 2022

Going to push as commit 234c17e.
Since your change was applied there have been 51 commits pushed to the master branch:

  • fc918a7: 8281234: The -protected option is not always checked in keytool and jarsigner
  • d80f697: 8282523: Fix 'hierachy' typo
  • f12200c: 8267796: vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java fails with NoClassDefFoundError
  • 12a822a: 8282381: Parallel: Remove unnecessary PCReferenceProcessor
  • ed3496e: 8282480: IGV: Use description instead of enum name for phases
  • fc52a21: 8282143: Objects.requireNonNull should be ForceInline
  • 732d891: 8282411: Add useful predicates to ElementKind
  • eac8021: 8282320: Remove case conversion for debugging log in SSLCipher
  • b86a8c0: 8282150: Drop redundant
    elements from tables in java.desktop HTML files
  • 941e97c: 8281738: Create a regression test for checking the 'Space' key activation of focused Button
  • ... and 41 more: https://git.openjdk.java.net/jdk/compare/b6843a162411b0fa32271592d8f3a6f241a54384...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 2, 2022
@openjdk openjdk bot closed this Mar 2, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 2, 2022
@openjdk
Copy link

openjdk bot commented Mar 2, 2022

@calvinccheung Pushed as commit 234c17e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@calvinccheung calvinccheung deleted the 8274788-archived-heap-obj-ParallelGC branch March 2, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants