-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8274788: Support archived heap objects in ParallelGC #7655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8274788: Support archived heap objects in ParallelGC #7655
Conversation
/label add hotspot-runtime |
👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into |
@calvinccheung |
@calvinccheung |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CDS and test changes look good to me.
@@ -0,0 +1,128 @@ | |||
/* | |||
* Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be 2022
@calvinccheung This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 51 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
Thanks Ioi, Albert, Thomas for the review. |
Going to push as commit 234c17e.
Your commit was automatically rebased without conflicts. |
@calvinccheung Pushed as commit 234c17e. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
With this change when the UseParallelGC is enabled, the CDS archived heap objects could be loaded
into the PSOldGen during VM bootstrap. This improves startup time since the module graph could be
loaded from the archive.
Passed CI tiers 1 - 4 tests.
Thanks @tschatzl for his help on GC changes.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7655/head:pull/7655
$ git checkout pull/7655
Update a local copy of the PR:
$ git checkout pull/7655
$ git pull https://git.openjdk.java.net/jdk pull/7655/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7655
View PR using the GUI difftool:
$ git pr show -t 7655
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7655.diff