New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8282515: More clean up on NativeLibraries just for JNI library use #7661
Conversation
👋 Welcome back mchung! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - thanks for cleaning up further. I think separating the library implementation makes a lot of sense. There's some duplication at the native level, but that's acceptable IMHO - and probably better than having a shared piece of logic that can work in two very different modes.
|
||
JVM_UnloadLibrary(handle); | ||
JNU_ReleaseStringPlatformChars(env, name, cname); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Watch out for the newline
@mlchung This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Thanks for the review. I also think this is better and cleaner separation. The duplicated native code is small and they just call |
/integrate |
This patch further cleans up NativeLibraries just for JNI library use. RawNativeLibraries implements its own native load and unload methods. In addition, this also fixes the implementation of
RawNativeLibraries::load
not to throw UnsatisfiedLinkError if a library cannot be loaded for any reason but instead returns null.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7661/head:pull/7661
$ git checkout pull/7661
Update a local copy of the PR:
$ git checkout pull/7661
$ git pull https://git.openjdk.java.net/jdk pull/7661/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7661
View PR using the GUI difftool:
$ git pr show -t 7661
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7661.diff