Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254975: lambda proxy fails to access a protected member inherited from a split package #767

Closed
wants to merge 3 commits into from

Conversation

@mlchung
Copy link
Member

@mlchung mlchung commented Oct 20, 2020

It's a bug in determining if a protected member inherited from a superclass is in
a split package as its host class that it only checks on the package name.

The fix is simple and compare the runtime package of the lambda class (which
is in the same runtime package as the host class) with that of the declaring class
of the protected member being accessed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x32 Linux x64 Windows x64 macOS x64
Build ✔️ (1/1 passed) ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) (1/9 failed) ✔️ (9/9 passed)

Failed test task

Issue

  • JDK-8254975: lambda proxy fails to access a protected member inherited from a split package

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/767/head:pull/767
$ git checkout pull/767

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 20, 2020

👋 Welcome back mchung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Oct 20, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 20, 2020

@mlchung The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 20, 2020

Webrevs

Loading

@mlchung
Copy link
Member Author

@mlchung mlchung commented Oct 20, 2020

/label remove hotspot-compiler

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 20, 2020

@mlchung
The hotspot-compiler label was successfully removed.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 29, 2020

@mlchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254975: lambda proxy fails to access a protected member inherited from a split package

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 174 new commits pushed to the master branch:

  • 2a2fa13: 8255449: Improve the exception message of MethodHandles::permuteArguments
  • 2a50c3f: 8241495: Make more compiler related flags available on a per method level
  • 5c520c3: 8255232: G1: Make G1BiasedMappedArray freeable
  • 9e5bbff: 8255550: x86: Assembler::cmpq(Address dst, Register src) encoding is incorrect
  • 5b18558: 8255243: Reinforce escape barrier interactions with ZGC conc stack processing
  • faf23de: 8255534: Shenandoah: Fix CmpP optimization wrt native-LRB
  • 579e50b: 8255564: InterpreterMacroAssembler::remove_activation() needs to restore thread right after VM call on x86_32
  • 4b20e46: 8255579: x86: Use cmpq(Register,Address) in safepoint_poll
  • 72ff8e2: 8254782: Fix benchmark issues in java/lang/StringIndexOfChar.java benchmark
  • ea26ff1: 8247614: java/nio/channels/DatagramChannel/Connect.java timed out
  • ... and 164 more: https://git.openjdk.java.net/jdk/compare/856037c4170074913a1e5a845e8d202d157319a5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Oct 29, 2020
@mlchung
Copy link
Member Author

@mlchung mlchung commented Oct 29, 2020

/integrate

Loading

@openjdk openjdk bot closed this Oct 29, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 29, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 29, 2020

@mlchung Since your change was applied there have been 175 commits pushed to the master branch:

  • d5138d1: 8255604: java/nio/channels/DatagramChannel/Connect.java fails with java.net.BindException: Cannot assign requested address: connect
  • 2a2fa13: 8255449: Improve the exception message of MethodHandles::permuteArguments
  • 2a50c3f: 8241495: Make more compiler related flags available on a per method level
  • 5c520c3: 8255232: G1: Make G1BiasedMappedArray freeable
  • 9e5bbff: 8255550: x86: Assembler::cmpq(Address dst, Register src) encoding is incorrect
  • 5b18558: 8255243: Reinforce escape barrier interactions with ZGC conc stack processing
  • faf23de: 8255534: Shenandoah: Fix CmpP optimization wrt native-LRB
  • 579e50b: 8255564: InterpreterMacroAssembler::remove_activation() needs to restore thread right after VM call on x86_32
  • 4b20e46: 8255579: x86: Use cmpq(Register,Address) in safepoint_poll
  • 72ff8e2: 8254782: Fix benchmark issues in java/lang/StringIndexOfChar.java benchmark
  • ... and 165 more: https://git.openjdk.java.net/jdk/compare/856037c4170074913a1e5a845e8d202d157319a5...master

Your commit was automatically rebased without conflicts.

Pushed as commit 5782a2a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants