8282615: G1: Fix some includes

[tschatzl]

Hi all,

can I have reviews for this simple change that fixes includes in some G1 files? The most serious is probably the one in g1CardSetContainers.hpp which included a .inline.hpp file directly.

Testing: local compilation, gha

Thanks,
Thomas

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8282615: G1: Fix some includes

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Ivan Walulya (@walulyai - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7677/head:pull/7677
$ git checkout pull/7677

Update a local copy of the PR:
$ git checkout pull/7677
$ git pull https://git.openjdk.java.net/jdk pull/7677/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7677

View PR using the GUI difftool:
$ git pr show -t 7677

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7677.diff

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (a6619cd4)

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282615: G1: Fix some includes

Reviewed-by: ayang, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

• 080baff: 8282483: Ensure that Utils.getAllInterfaces returns unique instances
• 57020fd: 8282582: Unused methods in Utils
• 5c187e3: 8282593: JDK-8281472 breaks 32-bit builds and gtests
• 7822cbc: 8276711: compiler/codecache/cli tests failing when SegmentedCodeCache used with -Xint
• 832729b: 6911375: mouseWheel has no effect without vertical scrollbar
• 0402a28: 8037965: NullPointerException in TextLayout.getBaselineFromGraphic() for JTextComponents
• d4d1fbc: 8282484: G1: Predicted old time in log always zero
• b1f935c: 8277055: Assert "missing inlining msg" with -XX:+PrintIntrinsics
• 2da6777: 8281122: [IR Framework] Cleanup IR matching code in preparation for JDK-8280378
• d0eb6fa: 8281569: Create tests for Frame.setMinimumSize() method
• ... and 8 more: https://git.openjdk.java.net/jdk/compare/12a822a2875568f4ffd683e8ad9451ebee03ee7e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tschatzl]

Thanks @walulyai @albertnetymk for your reviews.

/integrate

[openjdk]

Going to push as commit 5247153.
Since your change was applied there have been 28 commits pushed to the master branch:

• a584c90: 8282573: ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y)
• d5e8e52: 8282532: Allow explicitly setting build platform alongside --openjdk-target
• b383780: 8282343: Create a regression test for JDK-4518432
• b629782: 8279886: C1: Turn off SelectivePhiFunctions in presence of irreducible loops
• 7e1c67d: 8282608: RawNativeLibraryImpl can't be passed to NativeLibraries::findEntry0
• 8478173: 8282583: Update BCEL md to include the copyright notice
• fb6b929: 8277474: jarsigner does not check if algorithm parameters are disabled
• 1581e3f: 8282402: Create a regression test for JDK-4666101
• 268fa69: 8282511: Use fixed certificate validation date in SSLExampleCert template
• c777bb3: 8282619: G1: Fix indentation in G1CollectedHeap::mark_evac_failure_object
• ... and 18 more: https://git.openjdk.java.net/jdk/compare/12a822a2875568f4ffd683e8ad9451ebee03ee7e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit 5247153.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.