Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8282583: Update BCEL md to include the copyright notice #7681

Closed
wants to merge 2 commits into from

Conversation

JoeWang-Java
Copy link
Member

@JoeWang-Java JoeWang-Java commented Mar 3, 2022

Update BCEL md to include the copyright notice.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8282583: Update BCEL md to include the copyright notice

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7681/head:pull/7681
$ git checkout pull/7681

Update a local copy of the PR:
$ git checkout pull/7681
$ git pull https://git.openjdk.java.net/jdk pull/7681/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7681

View PR using the GUI difftool:
$ git pr show -t 7681

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7681.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 3, 2022

👋 Welcome back joehw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 3, 2022
@openjdk
Copy link

openjdk bot commented Mar 3, 2022

@JoeWang-Java The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Mar 3, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 3, 2022

Webrevs

Copy link
Contributor

@LanceAndersen LanceAndersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I assume the 2020 vs 2022 is intentional?

@openjdk
Copy link

openjdk bot commented Mar 3, 2022

@JoeWang-Java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282583: Update BCEL md to include the copyright notice

Reviewed-by: lancea, iris, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • fb6b929: 8277474: jarsigner does not check if algorithm parameters are disabled
  • 1581e3f: 8282402: Create a regression test for JDK-4666101
  • 268fa69: 8282511: Use fixed certificate validation date in SSLExampleCert template

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 3, 2022
Copy link
Member

@irisclark irisclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm 2020, not 2022. Otherwise, looks good.

@JoeWang-Java
Copy link
Member Author

Yes, it's 2020. The latest release, 6.5.0, was released in 2020. The text comes from the NOTICE.txt file in the BCEL 6.5.0 release.

@LanceAndersen
Copy link
Contributor

Yes, it's 2020. The latest release, 6.5.0, was released in 2020. The text comes from the NOTICE.txt file in the BCEL 6.5.0 release.

Thank you for the confirmation Joe!

@JoeWang-Java
Copy link
Member Author

Yes, it's 2020. The latest release, 6.5.0, was released in 2020. The text comes from the NOTICE.txt file in the BCEL 6.5.0 release.

Thank you for the confirmation Joe!

Thanks Lance, and Iris!

@JoeWang-Java
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 4, 2022

Going to push as commit 8478173.
Since your change was applied there have been 3 commits pushed to the master branch:

  • fb6b929: 8277474: jarsigner does not check if algorithm parameters are disabled
  • 1581e3f: 8282402: Create a regression test for JDK-4666101
  • 268fa69: 8282511: Use fixed certificate validation date in SSLExampleCert template

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 4, 2022
@openjdk openjdk bot closed this Mar 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 4, 2022
@openjdk
Copy link

openjdk bot commented Mar 4, 2022

@JoeWang-Java Pushed as commit 8478173.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@JoeWang-Java JoeWang-Java deleted the JDK-8282583 branch March 9, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
4 participants