New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8282583: Update BCEL md to include the copyright notice #7681
Conversation
👋 Welcome back joehw! A progress list of the required criteria for merging this PR into |
@JoeWang-Java The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. I assume the 2020 vs 2022 is intentional?
@JoeWang-Java This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirm 2020, not 2022. Otherwise, looks good.
Yes, it's 2020. The latest release, 6.5.0, was released in 2020. The text comes from the NOTICE.txt file in the BCEL 6.5.0 release. |
Thank you for the confirmation Joe! |
Thanks Lance, and Iris! |
/integrate |
Going to push as commit 8478173.
Your commit was automatically rebased without conflicts. |
@JoeWang-Java Pushed as commit 8478173. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Update BCEL md to include the copyright notice.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7681/head:pull/7681
$ git checkout pull/7681
Update a local copy of the PR:
$ git checkout pull/7681
$ git pull https://git.openjdk.java.net/jdk pull/7681/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7681
View PR using the GUI difftool:
$ git pr show -t 7681
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7681.diff