-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8282640: Create a test for JDK-4740761 #7686
Conversation
👋 Welcome back smandalika! A progress list of the required criteria for merging this PR into |
Webrevs
|
This review is for migrating tests from a closed test suite to open. |
@srmandal This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 406 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace, @mrserb) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
The test ran successfully on Mach5 with multiple runs (30) on windows-x64, linux-x64 and macos-x64. |
…ated, volatile focussedComponentName
/integrate |
@mrserb Can you please sponsor this PR? |
/sponsor |
Going to push as commit fad3b94.
Your commit was automatically rebased without conflicts. |
Create a test for JDK-4740761
The issue observed is in a JFrame with a JTextField and a JScrollPane which contains focused component. When the JScrollPane was
is removed from its parent, focus stays with the the scroller
of the removed JScrollPane, instead of moving to the TextField.
The test verifies the same - i.e. it verifies that the removal of the scrollpane moves the focus to the JTextField present in the JFrame.
This review is for migrating tests from a closed test suite to open.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7686/head:pull/7686
$ git checkout pull/7686
Update a local copy of the PR:
$ git checkout pull/7686
$ git pull https://git.openjdk.java.net/jdk pull/7686/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7686
View PR using the GUI difftool:
$ git pr show -t 7686
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7686.diff