Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8282640: Create a test for JDK-4740761 #7686

Closed
wants to merge 6 commits into from

Conversation

srmandal
Copy link

@srmandal srmandal commented Mar 4, 2022

Create a test for JDK-4740761

The issue observed is in a JFrame with a JTextField and a JScrollPane which contains focused component. When the JScrollPane was
is removed from its parent, focus stays with the the scroller
of the removed JScrollPane, instead of moving to the TextField.

The test verifies the same - i.e. it verifies that the removal of the scrollpane moves the focus to the JTextField present in the JFrame.
This review is for migrating tests from a closed test suite to open.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7686/head:pull/7686
$ git checkout pull/7686

Update a local copy of the PR:
$ git checkout pull/7686
$ git pull https://git.openjdk.java.net/jdk pull/7686/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7686

View PR using the GUI difftool:
$ git pr show -t 7686

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7686.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 4, 2022

👋 Welcome back smandalika! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 4, 2022

@srmandal The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 4, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 4, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 4, 2022

Webrevs

@srmandal
Copy link
Author

This review is for migrating tests from a closed test suite to open.

@openjdk
Copy link

openjdk bot commented Mar 24, 2022

@srmandal This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282640: Create a test for JDK-4740761

Reviewed-by: prr, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 406 new commits pushed to the master branch:

  • eab4c0c: 8283706: Add final or sealed modifier to appropriate javax.swing API classes
  • 3357d9a: 8284588: Remove GensrcCommonLangtools.gmk
  • a8c8752: 8284556: Ensure reachability of classes in runtime/whitebox/TestHiddenClassIsAlive.java and serviceability/dcmd/vm/ClassLoaderHierarchyTest.java
  • 662320a: 8284336: CDS SignedJar.java test fails due to archived Reference object
  • 1bd8975: 8284361: Updating ASM to 9.3 for JDK 19
  • 0a02675: 8279876: Clean up: isAssignableFrom usages in xpath and jdk internal classes
  • d6b4693: 8283698: Refactor Locale constructors used in src/test
  • 61698bd: 8284533: Improve InterpreterCodelet data footprint
  • 3a0ddeb: 8284378: Make Metal the default Java 2D rendering pipeline for macOS
  • b55c32f: 8284532: Memory leak in BitSet::BitMapFragmentTable in JFR leak profiler
  • ... and 396 more: https://git.openjdk.java.net/jdk/compare/b629782b8d44e8aa8a99c6a3381663a6169aa1ad...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace, @mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 24, 2022
@srmandal
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 24, 2022
@openjdk
Copy link

openjdk bot commented Mar 24, 2022

@srmandal
Your change (at version 4401622) is now ready to be sponsored by a Committer.

@srmandal
Copy link
Author

The test ran successfully on Mach5 with multiple runs (30) on windows-x64, linux-x64 and macos-x64.
@prrace Can you please sponsor this PR?

@openjdk openjdk bot removed the sponsor Pull request is ready to be sponsored label Mar 30, 2022
@srmandal
Copy link
Author

srmandal commented Apr 9, 2022

/integrate

@srmandal
Copy link
Author

srmandal commented Apr 9, 2022

@mrserb Can you please sponsor this PR?

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 9, 2022
@openjdk
Copy link

openjdk bot commented Apr 9, 2022

@srmandal
Your change (at version 141cd85) is now ready to be sponsored by a Committer.

@mrserb
Copy link
Member

mrserb commented Apr 12, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 12, 2022

Going to push as commit fad3b94.
Since your change was applied there have been 427 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 12, 2022
@openjdk openjdk bot closed this Apr 12, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 12, 2022
@openjdk
Copy link

openjdk bot commented Apr 12, 2022

@mrserb @srmandal Pushed as commit fad3b94.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@srmandal srmandal deleted the 8282640 branch October 20, 2022 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants