Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8282214: Upgrade JQuery to version 3.6.0 #7694

Closed
wants to merge 2 commits into from

Conversation

hns
Copy link
Member

@hns hns commented Mar 4, 2022

This is a straightforward change to update the jQuery library used in javadoc to version 3.6.0.

Both compressed and uncompressed versions of jQuery 3.6.0 were downloaded from https://jquery.com/download/ to replace the old version and all references in javadoc src and test code were updated to the new files.

In addition to running javadoc tests I did a manual test of features that use jQuery (search and mobile navbar) in Firefox, Chrome and Safari and they all work as expected.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7694/head:pull/7694
$ git checkout pull/7694

Update a local copy of the PR:
$ git checkout pull/7694
$ git pull https://git.openjdk.java.net/jdk pull/7694/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7694

View PR using the GUI difftool:
$ git pr show -t 7694

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7694.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 4, 2022

👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 4, 2022
@openjdk
Copy link

openjdk bot commented Mar 4, 2022

@hns The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the javadoc javadoc-dev@openjdk.org label Mar 4, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 4, 2022

Webrevs

Copy link
Contributor

@jonathan-gibbons jonathan-gibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's one additional reference in a comment that needs to be updated, but fix that and you're good to go.

@@ -1,9 +1,9 @@
## jQuery v3.5.1
## jQuery v3.6.0

### jQuery License
```
jQuery v 3.5.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this line need to be changed as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this, fixed in new commit.

@openjdk
Copy link

openjdk bot commented Mar 14, 2022

@hns This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282214: Upgrade JQuery to version 3.6.0

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 93 new commits pushed to the master branch:

  • 5bf6a7f: 8282691: add jdb "-R" option for passing any argument to the launched debuggee process
  • f66070b: 8282577: ICC_Profile.setData(int, byte[]) invalidates the profile
  • 70bd57e: 8283049: Fix non-singleton LoggerFinder error message: s/on/one
  • 7833667: 8282881: Print exception message in VM crash with -XX:AbortVMOnException
  • c96085e: 8282929: Localized monetary symbols are not reflected in toLocalizedPattern return value
  • 13cebff: 8058924: FileReader(String) documentation is insufficient
  • 08573cc: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket
  • ea9eeea: 8281322: C2: always construct strip mined loop initially (even if strip mining is disabled)
  • 5f3d403: 8272735: Add missing SubL node transformations
  • 01570ca: 8283017: GHA: Workflows break with update release versions
  • ... and 83 more: https://git.openjdk.java.net/jdk/compare/b629782b8d44e8aa8a99c6a3381663a6169aa1ad...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 14, 2022
@hns
Copy link
Member Author

hns commented Mar 14, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Mar 14, 2022

Going to push as commit 5ba5e21.
Since your change was applied there have been 94 commits pushed to the master branch:

  • a244051: 8283062: Uninitialized warnings in libgtest with GCC 11.2
  • 5bf6a7f: 8282691: add jdb "-R" option for passing any argument to the launched debuggee process
  • f66070b: 8282577: ICC_Profile.setData(int, byte[]) invalidates the profile
  • 70bd57e: 8283049: Fix non-singleton LoggerFinder error message: s/on/one
  • 7833667: 8282881: Print exception message in VM crash with -XX:AbortVMOnException
  • c96085e: 8282929: Localized monetary symbols are not reflected in toLocalizedPattern return value
  • 13cebff: 8058924: FileReader(String) documentation is insufficient
  • 08573cc: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket
  • ea9eeea: 8281322: C2: always construct strip mined loop initially (even if strip mining is disabled)
  • 5f3d403: 8272735: Add missing SubL node transformations
  • ... and 84 more: https://git.openjdk.java.net/jdk/compare/b629782b8d44e8aa8a99c6a3381663a6169aa1ad...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 14, 2022
@openjdk openjdk bot closed this Mar 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 14, 2022
@openjdk
Copy link

openjdk bot commented Mar 14, 2022

@hns Pushed as commit 5ba5e21.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org
2 participants