Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272691: Fix HotSpot style guide terminology for "non-local variables" #7695

Closed
wants to merge 3 commits into from

Conversation

kimbarrett
Copy link

@kimbarrett kimbarrett commented Mar 4, 2022

Please review this fix to incorrect terminology used in one place. The
correct terminology (per C++14 3.6.2) is "non-local variables".

As this is a HotSpot Style Guide change, it requires reviewers who are HotSpot
Group Members, though comments from others are welcome.

/label hotspot


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272691: Fix HotSpot style guide terminology for "non-local variables"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7695/head:pull/7695
$ git checkout pull/7695

Update a local copy of the PR:
$ git checkout pull/7695
$ git pull https://git.openjdk.java.net/jdk pull/7695/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7695

View PR using the GUI difftool:
$ git pr show -t 7695

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7695.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 4, 2022

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review hotspot hotspot-dev@openjdk.org labels Mar 4, 2022
@openjdk
Copy link

openjdk bot commented Mar 4, 2022

@kimbarrett
The hotspot label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Mar 4, 2022

Webrevs

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up.

@openjdk
Copy link

openjdk bot commented Mar 4, 2022

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272691: Fix HotSpot style guide terminology for "non-local variables"

Reviewed-by: dcubed, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 4, 2022
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Thanks,

@kimbarrett
Copy link
Author

Thanks @dcubed-ojdk and @dholmes-ora for reviews.

@kimbarrett
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 7, 2022

Going to push as commit 2e298b8.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 7, 2022
@openjdk openjdk bot closed this Mar 7, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 7, 2022
@openjdk
Copy link

openjdk bot commented Mar 7, 2022

@kimbarrett Pushed as commit 2e298b8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kimbarrett kimbarrett deleted the non-local-variables branch March 7, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
3 participants