Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252898: remove bulk registration of JFR CompilerPhaseType names #77

Closed
wants to merge 1 commit into from

Conversation

dougxc
Copy link
Member

@dougxc dougxc commented Sep 8, 2020

The changes made in JDK-8193210 support only bulk registration of compiler phase names with JFR. However, Graal only registers compiler phase names upon first execution of the phase since the set of phases is not known during VM initialization. This means registration of a Graal phase name needs to do unnecessary work, wrapping a single name into an array to conform to the bulk registration API. This pull request updates the registration API to be in terms of a registering a single phase name.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252898: remove bulk registration of JFR CompilerPhaseType names

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/77/head:pull/77
$ git checkout pull/77

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 8, 2020

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 8, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 8, 2020

@dougxc The following label will be automatically applied to this pull request: hotspot.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the hotspot label Sep 8, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 8, 2020

Webrevs

@dougxc
Copy link
Member Author

@dougxc dougxc commented Sep 8, 2020

/cc hotspot-compiler

@openjdk openjdk bot added the hotspot-compiler label Sep 8, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 8, 2020

@dougxc
The hotspot-compiler label was successfully added.

@dougxc
Copy link
Member Author

@dougxc dougxc commented Sep 10, 2020

@jamsheedcm could you please have a look at this change.

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Looks good.
I ran jfr/event/compiler tests with changes and they passed except TestCompilerInlining.java which failed before changes.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 12, 2020

@dougxc This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8252898: remove bulk registration of JFR CompilerPhaseType names

Reviewed-by: kvn, jcm
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 45 commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 779d2c34ae8ac26a3ddb637c2c6d830bded0cd5d.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 12, 2020
@vnkozlov
Copy link
Contributor

@vnkozlov vnkozlov commented Sep 12, 2020

I still want @jamsheedcm to review it too.

@dougxc
Copy link
Member Author

@dougxc dougxc commented Sep 14, 2020

/integrate

@openjdk openjdk bot closed this Sep 14, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 14, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2020

@dougxc Since your change was applied there have been 45 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit b05290a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dougxc dougxc deleted the JDK-8252898 branch Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-compiler integrated
3 participants