New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8252898: remove bulk registration of JFR CompilerPhaseType names #77
Conversation
|
@dougxc The following label will be automatically applied to this pull request: When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the |
Webrevs
|
/cc hotspot-compiler |
@dougxc |
@jamsheedcm could you please have a look at this change. |
Looks good.
I ran jfr/event/compiler tests with changes and they passed except TestCompilerInlining.java which failed before changes.
@dougxc This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements After integration, the commit message will be:
Since the source branch of this PR was last updated there have been 45 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge
|
I still want @jamsheedcm to review it too. |
/integrate |
@dougxc Since your change was applied there have been 45 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit b05290a. |
The changes made in JDK-8193210 support only bulk registration of compiler phase names with JFR. However, Graal only registers compiler phase names upon first execution of the phase since the set of phases is not known during VM initialization. This means registration of a Graal phase name needs to do unnecessary work, wrapping a single name into an array to conform to the bulk registration API. This pull request updates the registration API to be in terms of a registering a single phase name.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/77/head:pull/77
$ git checkout pull/77