Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254790: SIGSEGV in string_indexof_char and stringL_indexof_char intrinsics #772

Closed
wants to merge 1 commit into from

Conversation

sviswa7
Copy link

@sviswa7 sviswa7 commented Oct 20, 2020

The problem was due to 32 bit arithmetic instruction used for 64-bit address in
string_indexof_char and stringL_indexof_char: "addl(result, ch)".

This patch replaces the addl instruction with addptr and also enables the stringL_indexof_char intrinsic.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x32 Linux x64 Windows x64 macOS x64
Build ✔️ (1/1 passed) ❌ (3/5 failed) ❌ (2/2 failed) ✔️ (2/2 passed)
Test (tier1) ❌ (5/9 failed)

Failed test tasks

Issue

  • JDK-8254790: SIGSEGV in string_indexof_char and stringL_indexof_char intrinsics

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/772/head:pull/772
$ git checkout pull/772

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 20, 2020

👋 Welcome back sviswanathan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 20, 2020

@sviswa7 The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Oct 20, 2020
@sviswa7 sviswa7 changed the title RFR: 8254790: javax/xml/crypto/dsig/GenerationTests.java failed with SIGSEGV in C2 frame 8254790: javax/xml/crypto/dsig/GenerationTests.java failed with SIGSEGV in C2 frame Oct 20, 2020
@sviswa7 sviswa7 marked this pull request as ready for review October 20, 2020 20:30
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 20, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 20, 2020

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let me finish testing before integration.

@openjdk
Copy link

openjdk bot commented Oct 20, 2020

@sviswa7 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254790: SIGSEGV in string_indexof_char and stringL_indexof_char intrinsics

Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 41 new commits pushed to the master branch:

  • f813a28: 8254692: (se) Clarify the behaviour of the non-abstract SelectorProvider::inheritedChannel
  • c9269bf: 8255036: Shenandoah: Reset GC state for root verifier
  • 839f01d: 8242068: Signed JAR support for RSASSA-PSS and EdDSA
  • e559bd2: 8254889: name_and_sig_as_C_string usages in frame coding without ResourceMark
  • da97ab5: 8253474: Javadoc clean up in HttpsExchange, HttpsParameters, and HttpsServer
  • 7e26404: 8255000: C2: Unify IGVN processing when loop opts are over
  • 27230fa: 8255026: C2: Miscellaneous cleanups in Compile and PhaseIdealLoop code
  • c107178: 8253964: [Graal] UnschedulableGraphTest#test01fails with expected:<4> but was:<3>
  • bd45191: 8255065: Zero: accessor_entry misses the IRIW case
  • 2a06335: 8254785: compiler/graalunit/HotspotTest.java failed with "missing Graal intrinsics for: java/lang/StringLatin1.indexOfChar([BIII)I"
  • ... and 31 more: https://git.openjdk.java.net/jdk/compare/856037c4170074913a1e5a845e8d202d157319a5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 20, 2020
@vnkozlov
Copy link
Contributor

tier1-3 testing passed on x64 (all OSs).

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@neliasso
Copy link

Please change the bug title to something that describes the problem.

@mlbridge
Copy link

mlbridge bot commented Oct 21, 2020

Mailing list message from Viswanathan, Sandhya on hotspot-compiler-dev:

Thanks a lot Vladimir!

-----Original Message-----
From: hotspot-compiler-dev <hotspot-compiler-dev-retn at openjdk.java.net> On Behalf Of Vladimir Kozlov
Sent: Tuesday, October 20, 2020 8:41 PM
To: hotspot-compiler-dev at openjdk.java.net
Subject: Re: RFR: 8254790: javax/xml/crypto/dsig/GenerationTests.java failed with SIGSEGV in C2 frame

On Tue, 20 Oct 2020 21:52:30 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

The problem was due to 32 bit arithmetic instruction used for 64-bit
address in string_indexof_char and stringL_indexof_char: "addl(result, ch)".

This patch replaces the addl instruction with addptr and also enables the stringL_indexof_char intrinsic.

Looks good. Let me finish testing before integration.

tier1-3 testing passed on x64 (all OSs).

-------------

PR: https://git.openjdk.java.net/jdk/pull/772

@sviswa7 sviswa7 changed the title 8254790: javax/xml/crypto/dsig/GenerationTests.java failed with SIGSEGV in C2 frame 8254790: SIGSEGV in string_indexof_char and stringL_indexof_char intrinsics Oct 21, 2020
@sviswa7
Copy link
Author

sviswa7 commented Oct 21, 2020

Thanks a lot @TobiHartmann for the review.
@neliasso I have changed the bug title to "SIGSEGV in string_indexof_char and stringL_indexof_char intrinsics".

@sviswa7
Copy link
Author

sviswa7 commented Oct 21, 2020

/integrate

@openjdk openjdk bot closed this Oct 21, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 21, 2020
@openjdk
Copy link

openjdk bot commented Oct 21, 2020

@sviswa7 Since your change was applied there have been 41 commits pushed to the master branch:

  • f813a28: 8254692: (se) Clarify the behaviour of the non-abstract SelectorProvider::inheritedChannel
  • c9269bf: 8255036: Shenandoah: Reset GC state for root verifier
  • 839f01d: 8242068: Signed JAR support for RSASSA-PSS and EdDSA
  • e559bd2: 8254889: name_and_sig_as_C_string usages in frame coding without ResourceMark
  • da97ab5: 8253474: Javadoc clean up in HttpsExchange, HttpsParameters, and HttpsServer
  • 7e26404: 8255000: C2: Unify IGVN processing when loop opts are over
  • 27230fa: 8255026: C2: Miscellaneous cleanups in Compile and PhaseIdealLoop code
  • c107178: 8253964: [Graal] UnschedulableGraphTest#test01fails with expected:<4> but was:<3>
  • bd45191: 8255065: Zero: accessor_entry misses the IRIW case
  • 2a06335: 8254785: compiler/graalunit/HotspotTest.java failed with "missing Graal intrinsics for: java/lang/StringLatin1.indexOfChar([BIII)I"
  • ... and 31 more: https://git.openjdk.java.net/jdk/compare/856037c4170074913a1e5a845e8d202d157319a5...master

Your commit was automatically rebased without conflicts.

Pushed as commit 365f19c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sviswa7 sviswa7 deleted the JDK-8254970 branch June 1, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
4 participants