8255031 : Update java/util/prefs/AddNodeChangeListener.java to report more failure info

[bchristi-git]

Hi,

The java/util/prefs/AddNodeChangeListener.java test fails once in a while in the automated test system. Previous failures were traced to machine configuration errors, but that does not appear to be the case this time.

My efforts to reproduce this failure have been unsuccessful. The only useful information I've gleaned so far from the test failure logs is that the overall duration for running tier1 is longer than usual when the test failure happens.

I would like to make the following updates to the test, in hopes of learning more if and when this test fails again:

• fail faster, to report if it is addNode() or removeNode() that is failing
• make multiple attempts to sleep+check the NodeChangeListener. (If the test fails after a single sleep, but passes after waiting longer, maybe we just need to sleep for longer to account for the occasional slower tier1 test run).
• a few indentations fixes

Thanks,
-Brent

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Testing

	Linux x32	Linux x64	Windows x64	macOS x64
Build	✔️ (1/1 passed)	✔️ (5/5 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)
Test (tier1)		✔️ (9/9 passed)	❌ (1/9 failed)	✔️ (9/9 passed)

Failed test task

• Windows x64 (hs/tier1 compiler)

Issue

• JDK-8255031: Update java/util/prefs/AddNodeChangeListener.java to report more failure info

Reviewers

• Brian Burkhalter (@bplb - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/773/head:pull/773
$ git checkout pull/773

[bridgekeeper]

👋 Welcome back bchristi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bchristi-git The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (23eca90)
• 00: Full (5767bb3)

[openjdk]

@bchristi-git This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255031: Update java/util/prefs/AddNodeChangeListener.java to report more failure info

Reviewed-by: bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 48 new commits pushed to the master branch:

• 85a8949: 8254913: Increase InlineSmallCode default from 2000 to 2500 for x64
• 56ea490: 8233343: Deprecate -XX:+CriticalJNINatives flag which implements JavaCritical native functions
• 615b759: 8255070: Shenandoah: Use single thread for concurrent CLD liveness test
• 6020991: 8255068: [JVMCI] errors during compiler creation can be hidden
• 8d9e6d0: 8255041: Zero: remove old JSR 292 support leftovers
• 0efdde1: 8238669: Long.divideUnsigned is extremely slow for certain values (Needs to be Intrinsic)
• 365f19c: 8254790: SIGSEGV in string_indexof_char and stringL_indexof_char intrinsics
• f813a28: 8254692: (se) Clarify the behaviour of the non-abstract SelectorProvider::inheritedChannel
• c9269bf: 8255036: Shenandoah: Reset GC state for root verifier
• 839f01d: 8242068: Signed JAR support for RSASSA-PSS and EdDSA
• ... and 38 more: https://git.openjdk.java.net/jdk/compare/856037c4170074913a1e5a845e8d202d157319a5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bchristi-git]

/integrate

[openjdk]

@bchristi-git Since your change was applied there have been 65 commits pushed to the master branch:

• 0aa3c92: 8255262: Remove use of legacy custom @SPEC tag
• a0b687b: 8254854: [cgroups v1] Metric limits not properly detected on some join controller combinations
• f279ddf: 8248411: [aarch64] Insufficient error handling when CodeBuffer is exhausted
• 4634dbe: 8223312: Utilize handshakes instead of is_thread_fully_suspended
• cc50c8d: 8255196: Remove unused G1FullGCCompactionPoint::merge()
• ae72b52: 8255047: Add HotSpot UseDebuggerErgo flags
• 211bb62: 8255124: KeepAliveStreamCleaner may crash with java.lang.IllegalMonitorStateException: current thread is not owner
• 299e115: 8198395: Test javax/swing/plaf/metal/MetalLookAndFeel/Test8039750.java fails in mach5
• a5b7bc5: 7156347: javax/swing/JList/6462008/bug6462008.java fails
• b25d894: 8252204: AArch64: Implement SHA3 accelerator/intrinsic
• ... and 55 more: https://git.openjdk.java.net/jdk/compare/856037c4170074913a1e5a845e8d202d157319a5...master

Your commit was automatically rebased without conflicts.

Pushed as commit 8afdcae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.