8282295: SymbolPropertyEntry::set_method_type fails with assert

[coleenp]

This is somewhat trivial change to zero out OopHandle in fullgc_alot_dummy_array. Other OopHandle releases are for data that is deallocated or not reused so zeroing _obj is not needed in those places. I didn't want to zero _obj in OopHandle::release anyway without zeroing it in the analogous WeakHandle::release. WeakHandle release code operates on const objects, also which are deallocated after release.
Tested with tier1-4.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8282295: SymbolPropertyEntry::set_method_type fails with assert

Reviewers

• Harold Seigel (@hseigel - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7730/head:pull/7730
$ git checkout pull/7730

Update a local copy of the PR:
$ git checkout pull/7730
$ git pull https://git.openjdk.java.net/jdk pull/7730/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7730

View PR using the GUI difftool:
$ git pr show -t 7730

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7730.diff

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (8db52dce)

[hseigel]

Change looks good and trivial.
Thanks, Harold

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282295: SymbolPropertyEntry::set_method_type fails with assert

Reviewed-by: hseigel

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

• 0cbc4b8: 8281266: [JVMCI] MetaUtil.toInternalName() doesn't handle hidden classes correctly
• 0f88fc1: 8282769: BSD date cannot handle all ISO 8601 formats
• c6d743f: 8282770: Set source date in jib profiles from buildId
• 5fab27e: 8282144: RandomSupport.convertSeedBytesToLongs sign extension overwrites previous bytes
• 65ca0a5: 8276333: jdk/jfr/event/oldobject/TestLargeRootSet.java failed "assert(!contains(edge->reference())) failed: invariant"
• e607287: 8282728: Serial: Remove unused BlockOffsetArray::Action
• 8b45dbd: 8282312: Minor corrections to evbroadcasti32x4 intrinsic on x86
• 3f0684d: 8275775: Add jcmd VM.classes to print details of all classes
• cde923d: 8282690: runtime/CommandLine/VMDeprecatedOptions.java fails after JDK-8281181
• 50eb915: 8282632: Cleanup unnecessary calls to Throwable.initCause() in java.security.jgss
• ... and 13 more: https://git.openjdk.java.net/jdk/compare/894ffb098c80bfeb4209038c017d01dbf53fac0f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[coleenp]

Thanks Harold!
/integrate

[openjdk]

Going to push as commit 3e4dfc6.
Since your change was applied there have been 23 commits pushed to the master branch:

• 0cbc4b8: 8281266: [JVMCI] MetaUtil.toInternalName() doesn't handle hidden classes correctly
• 0f88fc1: 8282769: BSD date cannot handle all ISO 8601 formats
• c6d743f: 8282770: Set source date in jib profiles from buildId
• 5fab27e: 8282144: RandomSupport.convertSeedBytesToLongs sign extension overwrites previous bytes
• 65ca0a5: 8276333: jdk/jfr/event/oldobject/TestLargeRootSet.java failed "assert(!contains(edge->reference())) failed: invariant"
• e607287: 8282728: Serial: Remove unused BlockOffsetArray::Action
• 8b45dbd: 8282312: Minor corrections to evbroadcasti32x4 intrinsic on x86
• 3f0684d: 8275775: Add jcmd VM.classes to print details of all classes
• cde923d: 8282690: runtime/CommandLine/VMDeprecatedOptions.java fails after JDK-8281181
• 50eb915: 8282632: Cleanup unnecessary calls to Throwable.initCause() in java.security.jgss
• ... and 13 more: https://git.openjdk.java.net/jdk/compare/894ffb098c80bfeb4209038c017d01dbf53fac0f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit 3e4dfc6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[dholmes-ora]

Seems odd that there is not a way to NULL the pointer directly - why is it not done as part of release()?