Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8282932: a space is needed for the unsupported protocol exception message in ProtocolVersion #7769

Closed
wants to merge 2 commits into from

Conversation

johnshajiang
Copy link
Member

@johnshajiang johnshajiang commented Mar 10, 2022

In class sun.security.ssl.ProtocolVersion, the exception message for unsupported protocol needs a space.

ProtocolVersion pv = ProtocolVersion.nameOf(pn);
if (pv == null) {
    throw new IllegalArgumentException(
           "Unsupported protocol" + pn);
}

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8282932: a space is needed for the unsupported protocol exception message in ProtocolVersion

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7769/head:pull/7769
$ git checkout pull/7769

Update a local copy of the PR:
$ git checkout pull/7769
$ git pull https://git.openjdk.java.net/jdk pull/7769/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7769

View PR using the GUI difftool:
$ git pr show -t 7769

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7769.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 10, 2022

👋 Welcome back jjiang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 10, 2022
@openjdk
Copy link

openjdk bot commented Mar 10, 2022

@johnshajiang The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security label Mar 10, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 10, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 10, 2022

@johnshajiang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282932: a space is needed for the unsupported protocol exception message in ProtocolVersion

Reviewed-by: xuelei, mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • fdce97d: 8267820: (fs) Files.copy should attempt to copy POSIX attributes when target file in custom file system
  • e8a1ce0: 8280881: (fs) UnixNativeDispatcher.close0 may throw UnixException
  • 1668c02: 8277922: Unable to click JCheckBox in JTable through Java Access Bridge
  • 2674799: 8282878: Removed _JavaThread from PhaseTraceTime
  • 7c8ea9f: 8282509: [exploded image] ResolvedClassTest fails with similar output
  • 9c88c5b: 8282948: JDK-8274980 missed correct handling of MACOSX_BUNDLE_BUILD_VERSION
  • 83d7718: 8282893: Remove MacroAssembler::push/pop_callee_saved_registers
  • 6a3a7b9: 6218162: DefaultTableColumnModel.getColumn() method should mention ArrayIndexOutOfBoundsException
  • 5b78a82: 7017094: ParsedSynthStyle: parameter name "direction" should be changed to "tabIndex"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 10, 2022
@@ -290,7 +290,7 @@ static boolean isNegotiable(
ProtocolVersion pv = ProtocolVersion.nameOf(pn);
if (pv == null) {
throw new IllegalArgumentException(
"Unsupported protocol" + pn);
"Unsupported protocol " + pn);
Copy link
Member

@seanjmullan seanjmullan Mar 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should also add a colon so this reads better, i.e.: "Unsupported protocol: " + pn);

@johnshajiang
Copy link
Member Author

johnshajiang commented Mar 10, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Mar 10, 2022

Going to push as commit 1f29523.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 879b644: 8282897: Fix call parameter to GetStringChars() in HostLocaleProviderAdapter_md.c
  • fdce97d: 8267820: (fs) Files.copy should attempt to copy POSIX attributes when target file in custom file system
  • e8a1ce0: 8280881: (fs) UnixNativeDispatcher.close0 may throw UnixException
  • 1668c02: 8277922: Unable to click JCheckBox in JTable through Java Access Bridge
  • 2674799: 8282878: Removed _JavaThread from PhaseTraceTime
  • 7c8ea9f: 8282509: [exploded image] ResolvedClassTest fails with similar output
  • 9c88c5b: 8282948: JDK-8274980 missed correct handling of MACOSX_BUNDLE_BUILD_VERSION
  • 83d7718: 8282893: Remove MacroAssembler::push/pop_callee_saved_registers
  • 6a3a7b9: 6218162: DefaultTableColumnModel.getColumn() method should mention ArrayIndexOutOfBoundsException
  • 5b78a82: 7017094: ParsedSynthStyle: parameter name "direction" should be changed to "tabIndex"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Mar 10, 2022
@openjdk openjdk bot closed this Mar 10, 2022
@openjdk openjdk bot removed ready rfr labels Mar 10, 2022
@openjdk
Copy link

openjdk bot commented Mar 10, 2022

@johnshajiang Pushed as commit 1f29523.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@johnshajiang johnshajiang deleted the JDK-8282932 branch Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated security
3 participants