Skip to content

Conversation

@zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Mar 10, 2022

Please review this trivial patch to correct last parameter of GetStringChars() call, which should be a jboolean*, instead of jboolean


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8282897: Fix call parameter to GetStringChars() in HostLocaleProviderAdapter_md.c

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7775/head:pull/7775
$ git checkout pull/7775

Update a local copy of the PR:
$ git checkout pull/7775
$ git pull https://git.openjdk.java.net/jdk pull/7775/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7775

View PR using the GUI difftool:
$ git pr show -t 7775

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7775.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 10, 2022

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 10, 2022
@openjdk
Copy link

openjdk bot commented Mar 10, 2022

@zhengyu123 The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Mar 10, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 10, 2022

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@openjdk
Copy link

openjdk bot commented Mar 10, 2022

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282897: Fix call parameter to GetStringChars() in HostLocaleProviderAdapter_md.c

Reviewed-by: shade, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • e8a1ce0: 8280881: (fs) UnixNativeDispatcher.close0 may throw UnixException
  • 1668c02: 8277922: Unable to click JCheckBox in JTable through Java Access Bridge
  • 2674799: 8282878: Removed _JavaThread from PhaseTraceTime
  • 7c8ea9f: 8282509: [exploded image] ResolvedClassTest fails with similar output
  • 9c88c5b: 8282948: JDK-8274980 missed correct handling of MACOSX_BUNDLE_BUILD_VERSION
  • 83d7718: 8282893: Remove MacroAssembler::push/pop_callee_saved_registers
  • 6a3a7b9: 6218162: DefaultTableColumnModel.getColumn() method should mention ArrayIndexOutOfBoundsException
  • 5b78a82: 7017094: ParsedSynthStyle: parameter name "direction" should be changed to "tabIndex"
  • 8aba4de: 8249592: Robot.mouseMove moves cursor to incorrect location when display scale varies and Java runs in DPI Unaware mode
  • ff76620: 8282641: Make jdb "threadgroup" command with no args reset the current threadgroup back to the default
  • ... and 1 more: https://git.openjdk.java.net/jdk/compare/6d8d156c97b90a9ab4776c6b42563a962d959741...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 10, 2022
@zhengyu123
Copy link
Contributor Author

Looks fine to me.

Thanks, @shipilev

Copy link
Member

@naotoj naotoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

@zhengyu123
Copy link
Contributor Author

LGTM. Thanks for the fix!

Thanks for the review.

@zhengyu123
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 10, 2022

Going to push as commit 879b644.
Since your change was applied there have been 12 commits pushed to the master branch:

  • fdce97d: 8267820: (fs) Files.copy should attempt to copy POSIX attributes when target file in custom file system
  • e8a1ce0: 8280881: (fs) UnixNativeDispatcher.close0 may throw UnixException
  • 1668c02: 8277922: Unable to click JCheckBox in JTable through Java Access Bridge
  • 2674799: 8282878: Removed _JavaThread from PhaseTraceTime
  • 7c8ea9f: 8282509: [exploded image] ResolvedClassTest fails with similar output
  • 9c88c5b: 8282948: JDK-8274980 missed correct handling of MACOSX_BUNDLE_BUILD_VERSION
  • 83d7718: 8282893: Remove MacroAssembler::push/pop_callee_saved_registers
  • 6a3a7b9: 6218162: DefaultTableColumnModel.getColumn() method should mention ArrayIndexOutOfBoundsException
  • 5b78a82: 7017094: ParsedSynthStyle: parameter name "direction" should be changed to "tabIndex"
  • 8aba4de: 8249592: Robot.mouseMove moves cursor to incorrect location when display scale varies and Java runs in DPI Unaware mode
  • ... and 2 more: https://git.openjdk.java.net/jdk/compare/6d8d156c97b90a9ab4776c6b42563a962d959741...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 10, 2022
@openjdk openjdk bot closed this Mar 10, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 10, 2022
@openjdk
Copy link

openjdk bot commented Mar 10, 2022

@zhengyu123 Pushed as commit 879b644.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants