8282887: Potential memory leak in sun.util.locale.provider.HostLocaleProviderAdapterImpl.getNumberPattern() on Windows

[zhengyu123]

Please review this small patch that fixes early CHECK_NULL_RETURN results not releasing native jchar array returned by GetStringChars().

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8282887: Potential memory leak in sun.util.locale.provider.HostLocaleProviderAdapterImpl.getNumberPattern() on Windows

Reviewers

• Naoto Sato (@naotoj - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7777/head:pull/7777
$ git checkout pull/7777

Update a local copy of the PR:
$ git checkout pull/7777
$ git pull https://git.openjdk.java.net/jdk pull/7777/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7777

View PR using the GUI difftool:
$ git pr show -t 7777

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7777.diff

[bridgekeeper]

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@zhengyu123 The following labels will be automatically applied to this pull request:

• core-libs
• i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (e76c0bf9)

[naotoj]

LGTM.

[openjdk]

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282887: Potential memory leak in sun.util.locale.provider.HostLocaleProviderAdapterImpl.getNumberPattern() on Windows

Reviewed-by: naoto, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 45 new commits pushed to the master branch:

• 710653c: 8254786: java/net/httpclient/CancelRequestTest.java failing intermittently
• 34d4ffc: 8279317: compiler/jvmci/compilerToVM/DisassembleCodeBlobTest.java assumes immutable code
• 6013d09: 8268866: Javascript when used in an iframe cannot display search results
• 5ba5e21: 8282214: Upgrade JQuery to version 3.6.0
• a244051: 8283062: Uninitialized warnings in libgtest with GCC 11.2
• 5bf6a7f: 8282691: add jdb "-R" option for passing any argument to the launched debuggee process
• f66070b: 8282577: ICC_Profile.setData(int, byte[]) invalidates the profile
• 70bd57e: 8283049: Fix non-singleton LoggerFinder error message: s/on/one
• 7833667: 8282881: Print exception message in VM crash with -XX:AbortVMOnException
• c96085e: 8282929: Localized monetary symbols are not reflected in toLocalizedPattern return value
• ... and 35 more: https://git.openjdk.java.net/jdk/compare/6d8d156c97b90a9ab4776c6b42563a962d959741...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[zhengyu123]

Friendly ping. May I have a second review, please!

[zhengyu123]

Thanks, @naotoj @AlanBateman

[zhengyu123]

/integrate

[openjdk]

Going to push as commit 2cddf3f.
Since your change was applied there have been 45 commits pushed to the master branch:

• 710653c: 8254786: java/net/httpclient/CancelRequestTest.java failing intermittently
• 34d4ffc: 8279317: compiler/jvmci/compilerToVM/DisassembleCodeBlobTest.java assumes immutable code
• 6013d09: 8268866: Javascript when used in an iframe cannot display search results
• 5ba5e21: 8282214: Upgrade JQuery to version 3.6.0
• a244051: 8283062: Uninitialized warnings in libgtest with GCC 11.2
• 5bf6a7f: 8282691: add jdb "-R" option for passing any argument to the launched debuggee process
• f66070b: 8282577: ICC_Profile.setData(int, byte[]) invalidates the profile
• 70bd57e: 8283049: Fix non-singleton LoggerFinder error message: s/on/one
• 7833667: 8282881: Print exception message in VM crash with -XX:AbortVMOnException
• c96085e: 8282929: Localized monetary symbols are not reflected in toLocalizedPattern return value
• ... and 35 more: https://git.openjdk.java.net/jdk/compare/6d8d156c97b90a9ab4776c6b42563a962d959741...master

Your commit was automatically rebased without conflicts.

[openjdk]

@zhengyu123 Pushed as commit 2cddf3f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.