-
Notifications
You must be signed in to change notification settings - Fork 6.2k
JDK-8282933: Create a test for JDK-4529616 #7783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back smandalika! A progress list of the required criteria for merging this PR into |
Webrevs
|
|
Hi! Can someone please take a look at PR and provide their valuable feedback ? |
|
@srmandal This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 543 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
/integrate |
|
@mrserb Can you please sponsor this PR? |
|
The test ran successfully on Mach5 with multiple runs (30) on windows-x64, linux-x64 and macos-x64. |
|
/sponsor |
|
Going to push as commit a0b984a.
Your commit was automatically rebased without conflicts. |
JDK-8282933: Create a test for JDK-4529616
AccessibleJTableCell.isShowing() returns false when the cell is actually on
the screen.
The test validates the fix for the above issue by verifying that the isShowing call returns true when invoked via the accessiblity context.
This review is for migrating tests from a closed test suite to open.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7783/head:pull/7783$ git checkout pull/7783Update a local copy of the PR:
$ git checkout pull/7783$ git pull https://git.openjdk.java.net/jdk pull/7783/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7783View PR using the GUI difftool:
$ git pr show -t 7783Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7783.diff