-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8282929: Localized monetary symbols are not reflected in toLocalizedPattern
return value
#7790
Conversation
…Pattern` return value
👋 Welcome back naoto! A progress list of the required criteria for merging this PR into |
Webrevs
|
@naotoj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 26 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
* @bug 8282929 | ||
* @summary Verifies that toLocalizedPattern() method correctly returns | ||
* monetary symbols in a currency formatter | ||
* @run testng ToLocalizedPatternTest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe run in othervm mode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Lance. I believe it is OK to run it in samejvm mode, as it does not leave any side effects.
/integrate |
Going to push as commit c96085e.
Your commit was automatically rebased without conflicts. |
DecimalFormat.toLocalizedPattern()
was not honoring the monetary decimal/grouping separator symbols. Fix is straightforward to use the correct symbols depending on the formatter type.Progress
Issue
toLocalizedPattern
return valueReviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7790/head:pull/7790
$ git checkout pull/7790
Update a local copy of the PR:
$ git checkout pull/7790
$ git pull https://git.openjdk.java.net/jdk pull/7790/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7790
View PR using the GUI difftool:
$ git pr show -t 7790
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7790.diff