Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8282929: Localized monetary symbols are not reflected in toLocalizedPattern return value #7790

Closed
wants to merge 2 commits into from

Conversation

naotoj
Copy link
Member

@naotoj naotoj commented Mar 11, 2022

DecimalFormat.toLocalizedPattern() was not honoring the monetary decimal/grouping separator symbols. Fix is straightforward to use the correct symbols depending on the formatter type.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8282929: Localized monetary symbols are not reflected in toLocalizedPattern return value

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7790/head:pull/7790
$ git checkout pull/7790

Update a local copy of the PR:
$ git checkout pull/7790
$ git pull https://git.openjdk.java.net/jdk pull/7790/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7790

View PR using the GUI difftool:
$ git pr show -t 7790

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7790.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 11, 2022

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 11, 2022

@naotoj The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Mar 11, 2022
@naotoj naotoj marked this pull request as ready for review March 11, 2022 20:42
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 11, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 11, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 12, 2022

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282929: Localized monetary symbols are not reflected in `toLocalizedPattern` return value

Reviewed-by: joehw, lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

  • 5c408c1: 8282874: Bad performance on gather/scatter API caused by different IntSpecies of indexMap
  • 374193b: 8283041: [javadoc] Crashes using {@return} with @param
  • 0fd09d3: 8282978: Wrong parameter passed to GetStringXXXChars in various places
  • 95ca944: 8282354: Remove dependancy of TestHttpServer, HttpTransaction, HttpCallback from open/test/jdk/ tests
  • f99193a: 8282811: Typo in IAE details message of RecordedObject.getValueDescriptor
  • cab9def: 8282700: Properly handle several --without options during configure
  • 1a5a496: 8282763: G1: G1CardSetContainer remove intrusive-list details.
  • 88f0938: 8272493: Suboptimal code generation around Preconditions.checkIndex intrinsic with AVX2
  • a5a1a32: 8282883: Use JVM_LEAF to avoid ThreadStateTransition for some simple JVM entries
  • bb7ee5a: 8282314: nsk/jvmti/SuspendThread/suspendthrd003 may leak memory
  • ... and 16 more: https://git.openjdk.java.net/jdk/compare/70318e1d17072198be5674ebe7118fb5f9373144...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 12, 2022
* @bug 8282929
* @summary Verifies that toLocalizedPattern() method correctly returns
* monetary symbols in a currency formatter
* @run testng ToLocalizedPatternTest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe run in othervm mode?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Lance. I believe it is OK to run it in samejvm mode, as it does not leave any side effects.

@naotoj
Copy link
Member Author

naotoj commented Mar 14, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Mar 14, 2022

Going to push as commit c96085e.
Since your change was applied there have been 34 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 14, 2022
@openjdk openjdk bot closed this Mar 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 14, 2022
@openjdk
Copy link

openjdk bot commented Mar 14, 2022

@naotoj Pushed as commit c96085e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants