8283056: show abstract machine code in hs-err for all VM crashes #7791

dougxc · 2022-03-11T20:48:06Z

JDK-8272586 added abstract assembly to hs-err for methods on the stack of the crashing thread. However, it only does this if the crash is due to an unhandled signal. It can also be useful to see assembly for crashes due to failing VM assertions or guarantees. This PR implements this improvement.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8283056: show abstract machine code in hs-err for all VM crashes

Reviewers

Tobias Hartmann (@TobiHartmann - Reviewer) ⚠️ Review applies to 3ef8637
David Holmes (@dholmes-ora - Reviewer) ⚠️ Review applies to 3ef8637

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7791/head:pull/7791
$ git checkout pull/7791

Update a local copy of the PR:
$ git checkout pull/7791
$ git pull https://git.openjdk.java.net/jdk pull/7791/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7791

View PR using the GUI difftool:
$ git pr show -t 7791

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7791.diff

bridgekeeper · 2022-03-11T20:49:41Z

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-03-11T20:51:32Z

@dougxc The following label will be automatically applied to this pull request:

hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-03-12T14:43:11Z

Webrevs

01: Full - Incremental (a1adb8aa)
00: Full (3ef8637d)

dougxc · 2022-03-12T16:27:26Z

I've tested this manually by hacking a guarantee failure into a code path I know is called from Graal compiled code. Suggestions on how to write an automatic test that can be part of this PR are welcome.

dougxc · 2022-03-13T20:05:42Z

/label add hotspot-compiler

openjdk · 2022-03-13T20:06:10Z

@dougxc
The hotspot-compiler label was successfully added.

TobiHartmann · 2022-03-14T06:03:43Z

Suggestions on how to write an automatic test that can be part of this PR are welcome.

What about using -XX:CICrashAt and other flags that trigger asserts? You can have a look at TestDwarf.java in Christian's PR #7126.

dougxc · 2022-03-14T14:02:50Z

What about using -XX:CICrashAt and other flags that trigger asserts

CICrashAt triggers an assertion during compilation where as I need an assertion or guarantee in VM code called from JIT compiled code. To be completely reliable, this needs a runtime entry point to assert, guarantee or fatal that can be called from compiled code. JVMCI has such an entry point for fatal (JVMCIRuntime::vm_message) but without Graal in the JDK, it's hard to write a test that uses it. I've done such testing manually so am confident that it works.

TobiHartmann

Okay, makes sense. The change looks reasonable to me but someone from the runtime folks should have a look as well.

TobiHartmann · 2022-03-15T09:28:16Z

/reviewers 2

openjdk · 2022-03-15T09:29:28Z

@TobiHartmann
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

dholmes-ora

Hi Doug,

I'm approving in principle but would like to see the code tweaked as per the comment below.

Thanks,
David

dholmes-ora · 2022-03-17T06:25:51Z

src/hotspot/share/utilities/vmError.cpp

+       frame fr = _context ? os::fetch_frame_from_context(_context)
+                           : os::current_frame();


This seems like it is only need in the else branch at L931, so I'd prefer to see it there please.

openjdk · 2022-03-17T10:29:56Z

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283056: show abstract machine code in hs-err for all VM crashes

Reviewed-by: thartmann, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 43 new commits pushed to the master branch:

bad658e: 8282727: Parallel: Remove PSPromotionManager::_totally_drain
beedae1: 8281146: Replace StringCoding.hasNegatives with countPositives
249d553: 8282602: Refactor awt classes javadoc to use @throws instead of @exception
096bca4: 8282473: Refactor swing classes javadoc to use @throws instead of @exception
a5ebcc0: 8282072: G1: Rename CardSetPtr to CardSetContainerPtr
3da5204: 8283229: compiler/arguments/TestCodeEntryAlignment.java fails with release VMs
3e39304: 8281631: HashMap copy constructor and putAll can over-allocate table
0cf291b: 8283234: Improve @jls usage in java.base
9b8afce: 8283260: gcc is not supported on mac
08cadb4: 8271195: Use largest available large page size smaller than LargePageSizeInBytes when available
... and 33 more: https://git.openjdk.java.net/jdk/compare/0fd09d383b9921f26d2d609ab330630a4520325a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

dougxc · 2022-03-17T10:30:45Z

Thanks @dholmes-ora , I've made the suggested change: a1adb8a

dougxc · 2022-03-17T12:49:38Z

/integrate

openjdk · 2022-03-17T12:51:22Z

Going to push as commit 69e4e33.
Since your change was applied there have been 43 commits pushed to the master branch:

bad658e: 8282727: Parallel: Remove PSPromotionManager::_totally_drain
beedae1: 8281146: Replace StringCoding.hasNegatives with countPositives
249d553: 8282602: Refactor awt classes javadoc to use @throws instead of @exception
096bca4: 8282473: Refactor swing classes javadoc to use @throws instead of @exception
a5ebcc0: 8282072: G1: Rename CardSetPtr to CardSetContainerPtr
3da5204: 8283229: compiler/arguments/TestCodeEntryAlignment.java fails with release VMs
3e39304: 8281631: HashMap copy constructor and putAll can over-allocate table
0cf291b: 8283234: Improve @jls usage in java.base
9b8afce: 8283260: gcc is not supported on mac
08cadb4: 8271195: Use largest available large page size smaller than LargePageSizeInBytes when available
... and 33 more: https://git.openjdk.java.net/jdk/compare/0fd09d383b9921f26d2d609ab330630a4520325a...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-03-17T12:51:40Z

@dougxc Pushed as commit 69e4e33.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

show abstract machine code for all VM crashes

3ef8637

openjdk bot added the hotspot hotspot-dev@openjdk.org label Mar 11, 2022

dougxc marked this pull request as ready for review March 12, 2022 14:38

openjdk bot added the rfr Pull request is ready for review label Mar 12, 2022

openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Mar 13, 2022

TobiHartmann approved these changes Mar 15, 2022

View reviewed changes

dholmes-ora approved these changes Mar 17, 2022

View reviewed changes

moved fr declaration to block where it is used

a1adb8a

dougxc changed the title ~~8283056: show abstract machine code for all VM crashes~~ 8283056: show abstract machine code in hs-err for all VM crashes Mar 17, 2022

openjdk bot added the ready Pull request is ready to be integrated label Mar 17, 2022

openjdk bot added the integrated Pull request has been integrated label Mar 17, 2022

openjdk bot closed this Mar 17, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 17, 2022

dougxc deleted the JDK-8283056 branch May 23, 2023 07:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8283056: show abstract machine code in hs-err for all VM crashes #7791

8283056: show abstract machine code in hs-err for all VM crashes #7791

dougxc commented Mar 11, 2022 •

edited by openjdk bot

Loading

bridgekeeper bot commented Mar 11, 2022

openjdk bot commented Mar 11, 2022

mlbridge bot commented Mar 12, 2022 •

edited

Loading

dougxc commented Mar 12, 2022

dougxc commented Mar 13, 2022

openjdk bot commented Mar 13, 2022

TobiHartmann commented Mar 14, 2022

dougxc commented Mar 14, 2022

TobiHartmann left a comment

TobiHartmann commented Mar 15, 2022

openjdk bot commented Mar 15, 2022

dholmes-ora left a comment

dholmes-ora Mar 17, 2022

openjdk bot commented Mar 17, 2022

dougxc commented Mar 17, 2022

dougxc commented Mar 17, 2022

openjdk bot commented Mar 17, 2022

openjdk bot commented Mar 17, 2022

		frame fr = _context ? os::fetch_frame_from_context(_context)
		: os::current_frame();

8283056: show abstract machine code in hs-err for all VM crashes #7791

8283056: show abstract machine code in hs-err for all VM crashes #7791

Conversation

dougxc commented Mar 11, 2022 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Mar 11, 2022

openjdk bot commented Mar 11, 2022

mlbridge bot commented Mar 12, 2022 • edited Loading

Webrevs

dougxc commented Mar 12, 2022

dougxc commented Mar 13, 2022

openjdk bot commented Mar 13, 2022

TobiHartmann commented Mar 14, 2022

dougxc commented Mar 14, 2022

TobiHartmann left a comment

Choose a reason for hiding this comment

TobiHartmann commented Mar 15, 2022

openjdk bot commented Mar 15, 2022

dholmes-ora left a comment

Choose a reason for hiding this comment

dholmes-ora Mar 17, 2022

Choose a reason for hiding this comment

openjdk bot commented Mar 17, 2022

dougxc commented Mar 17, 2022

dougxc commented Mar 17, 2022

openjdk bot commented Mar 17, 2022

openjdk bot commented Mar 17, 2022

dougxc commented Mar 11, 2022 •

edited by openjdk bot

Loading

mlbridge bot commented Mar 12, 2022 •

edited

Loading