Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8236128: Allow jpackage create installers for services #7793

Closed

Conversation

alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Mar 11, 2022

Implementation of JDK-8275062: "Allow jpackage create installers for services"
CSR


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed
  • Change requires a CSR request to be approved

Issues

  • JDK-8236128: Allow jpackage create installers for services
  • JDK-8275062: Allow jpackage create installers for services (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7793/head:pull/7793
$ git checkout pull/7793

Update a local copy of the PR:
$ git checkout pull/7793
$ git pull https://git.openjdk.java.net/jdk pull/7793/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7793

View PR using the GUI difftool:
$ git pr show -t 7793

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7793.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 11, 2022

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 11, 2022

⚠️ @alexeysemenyukoracle This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@openjdk
Copy link

openjdk bot commented Mar 11, 2022

@alexeysemenyukoracle The following labels will be automatically applied to this pull request:

  • build
  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org csr Pull request needs approved CSR before integration labels Mar 11, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 11, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 11, 2022

Webrevs

@erikj79
Copy link
Member

erikj79 commented Mar 15, 2022

Build change looks good.

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Apr 9, 2022
@openjdk
Copy link

openjdk bot commented Apr 9, 2022

@alexeysemenyukoracle this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8236128
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added merge-conflict Pull request has merge conflict with target branch and removed rfr Pull request is ready for review labels Apr 9, 2022
@openjdk
Copy link

openjdk bot commented Apr 14, 2022

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8236128: Allow jpackage create installers for services

Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 48 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review and removed merge-conflict Pull request has merge conflict with target branch labels Apr 14, 2022
@victordyakov
Copy link

Approved

@williamharnois
Copy link

williamharnois commented Apr 26, 2022

Hi @williamharnois, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user williamharnois for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

@alexeysemenyukoracle
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 27, 2022

Going to push as commit b675c59.
Since your change was applied there have been 204 commits pushed to the master branch:

  • ef27081: 8285671: java/nio/channels/etc/PrintSupportedOptions.java and java/nio/channels/DatagramChannel/AfterDisconnect.java are failing
  • 4919525: 8285440: Typo in Collections.addAll method javadoc
  • e7c3b9d: 8285617: Fix java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java manual test
  • 16a8ebb: 8285675: Temporary fix for arm32 SafeFetch
  • 72f82dd: 8208565: [TEST_BUG] javax\swing\PopupFactory\6276087\NonOpaquePopupMenuTest.java throws NPE
  • 4714fdc: 8285279: ArgumentsTest.set_numeric_flag_double_vm fails on some locales (again)
  • cc89f1b: 8198622: java/awt/Focus/TypeAhead/TestFocusFreeze.java fails on mac
  • d3ea4b7: 8283435: AArch64: [vectorapi] Optimize SVE lane/withLane operations for 64/128-bit vector sizes
  • 16ebe40: 8251177: [macosx] The text "big" is truncated in JTabbedPane
  • e574cc0: 8196367: java/awt/List/SingleModeDeselect/SingleModeDeselect.java times out
  • ... and 194 more: https://git.openjdk.java.net/jdk/compare/f4edb59a6e44d99ba215ee6970ffa6fb26b4798c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 27, 2022
@openjdk openjdk bot closed this Apr 27, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 27, 2022
@openjdk
Copy link

openjdk bot commented Apr 27, 2022

@alexeysemenyukoracle Pushed as commit b675c59.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
5 participants