New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8282937: Write a regression test for JSplitPane divider drag color changes #7803
Conversation
|
@manukumarvs The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
test/jdk/javax/swing/JSplitPane/4820080/JSplitPaneDragColorTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, please confirm that mach5 is green before integration.
@manukumarvs This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 314 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well.
|
Confirmed with Mach5 execution in Linux,Mac and Windows machines(10 times run in each platform) and got all pass. |
/integrate |
@manukumarvs |
/sponsor |
Going to push as commit 849b195.
Your commit was automatically rebased without conflicts. |
@mrserb @manukumarvs Pushed as commit 849b195. |
Write a regression test for JDK-4820080 : RFE: Cannot Change the JSplitPane Divider Color while dragging
Issue(as per bug description):
I want to change the color of the JSplitPane divider. I
opened the code and found that, the color is hard coded to
darkGray while one is dragging the splitDivider. I have an
application where the components on SplitPane have black
background, So when i drag I can not see the split getting
dragged. Can some one fix this, by externelising the
SplitDivider color so that it can be changed at run time.
Testing:
Java 1.4.1 -> Test Failed.
$ ./j2sdk1.4.1/bin/java JSplitPaneDragColorTest
Metal uses correct drag color false
CDE/Motif uses correct drag color false
Windows uses correct drag color false
Test Failed.
Java 1.5.0 -> Test Passed.
$ ./jdk1.5.0/bin/java JSplitPaneDragColorTest
Metal uses correct drag color true
Windows uses correct drag color true
Windows Classic uses correct drag color true
Test Passed.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7803/head:pull/7803
$ git checkout pull/7803
Update a local copy of the PR:
$ git checkout pull/7803
$ git pull https://git.openjdk.java.net/jdk pull/7803/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7803
View PR using the GUI difftool:
$ git pr show -t 7803
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7803.diff