Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8282937: Write a regression test for JSplitPane divider drag color changes #7803

Closed
wants to merge 2 commits into from

Conversation

manukumarvs
Copy link
Member

@manukumarvs manukumarvs commented Mar 13, 2022

Write a regression test for JDK-4820080 : RFE: Cannot Change the JSplitPane Divider Color while dragging

Issue(as per bug description):
I want to change the color of the JSplitPane divider. I
opened the code and found that, the color is hard coded to
darkGray while one is dragging the splitDivider. I have an
application where the components on SplitPane have black
background, So when i drag I can not see the split getting
dragged. Can some one fix this, by externelising the
SplitDivider color so that it can be changed at run time.

Testing:
Java 1.4.1 -> Test Failed.
$ ./j2sdk1.4.1/bin/java JSplitPaneDragColorTest
Metal uses correct drag color false
CDE/Motif uses correct drag color false
Windows uses correct drag color false
Test Failed.

Java 1.5.0 -> Test Passed.
$ ./jdk1.5.0/bin/java JSplitPaneDragColorTest
Metal uses correct drag color true
Windows uses correct drag color true
Windows Classic uses correct drag color true
Test Passed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7803/head:pull/7803
$ git checkout pull/7803

Update a local copy of the PR:
$ git checkout pull/7803
$ git pull https://git.openjdk.java.net/jdk pull/7803/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7803

View PR using the GUI difftool:
$ git pr show -t 7803

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7803.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 13, 2022

👋 Welcome back mvs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 13, 2022
@openjdk
Copy link

openjdk bot commented Mar 13, 2022

@manukumarvs The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 13, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 13, 2022

Webrevs

Copy link
Member

@mrserb mrserb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, please confirm that mach5 is green before integration.

@openjdk
Copy link

openjdk bot commented Mar 16, 2022

@manukumarvs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282937: Write a regression test for JDK-4820080

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 314 new commits pushed to the master branch:

  • 3da5204: 8283229: compiler/arguments/TestCodeEntryAlignment.java fails with release VMs
  • 3e39304: 8281631: HashMap copy constructor and putAll can over-allocate table
  • 0cf291b: 8283234: Improve @jls usage in java.base
  • 9b8afce: 8283260: gcc is not supported on mac
  • 08cadb4: 8271195: Use largest available large page size smaller than LargePageSizeInBytes when available
  • de4f04c: 8253495: CDS generates non-deterministic output
  • 4df24c5: 8283230: Improve @jls usage in ElementType
  • 27fe3d7: 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled
  • bacfaa3: 8282414: x86: Enhance the assembler to generate more compact instructions
  • 1465ea9: 8282355: compiler/arguments/TestCodeEntryAlignment.java failed "guarantee(sect->end() <= tend) failed: sanity"
  • ... and 304 more: https://git.openjdk.java.net/jdk/compare/f07b8165231799383303e5c0755d07afd2feb7fd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 16, 2022
@manukumarvs
Copy link
Member Author

Looks fine, please confirm that mach5 is green before integration.

Confirmed with Mach5 execution in Linux,Mac and Windows machines(10 times run in each platform) and got all pass.

@manukumarvs
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 17, 2022
@openjdk
Copy link

openjdk bot commented Mar 17, 2022

@manukumarvs
Your change (at version afb0a2b) is now ready to be sponsored by a Committer.

@mrserb
Copy link
Member

mrserb commented Mar 22, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 22, 2022

Going to push as commit 849b195.
Since your change was applied there have been 360 commits pushed to the master branch:

  • 81d6373: 8282469: Allow considered use of C++ thread_local in Hotspot
  • f3dc0c8: 8282721: HotSpot Style Guide should allow considered use of C++ thread_local
  • f8878cb: 8257733: Move module-specific data from make to respective module
  • 14b9e80: 8283415: Update java.lang.ref to use sealed classes
  • f4f8728: 8283097: Parallel: Move filler object logic inside PSPromotionLAB::unallocate_object
  • 19d34bd: 8281879: Serial: Merge CardGeneration into TenuredGeneration
  • 999da9b: 8282306: os::is_first_C_frame(frame*) crashes on invalid link access
  • c4dc58e: 8283277: ISO 4217 Amendment 171 Update
  • cb576da: 8283379: Memory leak in FileHeaderHelper
  • 909986c: 8283217: Leak FcObjectSet in getFontConfigLocations() in fontpath.c
  • ... and 350 more: https://git.openjdk.java.net/jdk/compare/f07b8165231799383303e5c0755d07afd2feb7fd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 22, 2022
@openjdk openjdk bot closed this Mar 22, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 22, 2022
@openjdk
Copy link

openjdk bot commented Mar 22, 2022

@mrserb @manukumarvs Pushed as commit 849b195.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@manukumarvs manukumarvs deleted the 8282937 branch May 4, 2022 07:48
@manukumarvs manukumarvs changed the title 8282937: Write a regression test for JDK-4820080 8282937: Write a regression test for JSplitPane drag color changes Oct 12, 2022
@manukumarvs manukumarvs changed the title 8282937: Write a regression test for JSplitPane drag color changes 8282937: Write a regression test for JSplitPane divider drag color changes Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants