Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8283087: Create a test or JDK-4715503 #7807

Closed
wants to merge 2 commits into from

Conversation

srmandal
Copy link

@srmandal srmandal commented Mar 14, 2022

Create a test or JDK-4715503

The getAccessibleContext method for JTable column header cells returns an
AccessibleContext which cannot get the Bounding Rectangle for table header cells. The Bug causes problems with screen reader review mode.

The test added verifies that the are not exceptions and Bounding rectangles are returned for the Accessible Table Header Cells.

This review is for migrating tests from a closed test suite to open.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7807/head:pull/7807
$ git checkout pull/7807

Update a local copy of the PR:
$ git checkout pull/7807
$ git pull https://git.openjdk.java.net/jdk pull/7807/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7807

View PR using the GUI difftool:
$ git pr show -t 7807

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7807.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 14, 2022

👋 Welcome back smandalika! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 14, 2022
@openjdk
Copy link

openjdk bot commented Mar 14, 2022

@srmandal The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 14, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 14, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 16, 2022

@srmandal This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283087: Create a test or JDK-4715503

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

  • 3da5204: 8283229: compiler/arguments/TestCodeEntryAlignment.java fails with release VMs
  • 3e39304: 8281631: HashMap copy constructor and putAll can over-allocate table
  • 0cf291b: 8283234: Improve @jls usage in java.base
  • 9b8afce: 8283260: gcc is not supported on mac
  • 08cadb4: 8271195: Use largest available large page size smaller than LargePageSizeInBytes when available
  • de4f04c: 8253495: CDS generates non-deterministic output
  • 4df24c5: 8283230: Improve @jls usage in ElementType
  • 27fe3d7: 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled
  • bacfaa3: 8282414: x86: Enhance the assembler to generate more compact instructions
  • 1465ea9: 8282355: compiler/arguments/TestCodeEntryAlignment.java failed "guarantee(sect->end() <= tend) failed: sanity"
  • ... and 24 more: https://git.openjdk.java.net/jdk/compare/fde31498963d76630ada31bd0e0cf3035f87445b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 16, 2022
@srmandal
Copy link
Author

/integrate

@srmandal
Copy link
Author

@mrserb Can you please sponsor my changes?

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 17, 2022
@openjdk
Copy link

openjdk bot commented Mar 17, 2022

@srmandal
Your change (at version 2976ae1) is now ready to be sponsored by a Committer.

@mrserb
Copy link
Member

mrserb commented Mar 22, 2022

@srmandal please confirm that the test works fine in the mach5.

@srmandal
Copy link
Author

@mrserb Yes The test ran successfully on Mach5 with multiple runs (30) on windows-x64, linux-x64 and macos-x64.

@mrserb
Copy link
Member

mrserb commented Mar 22, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 22, 2022

Going to push as commit a6fd0b2.
Since your change was applied there have been 82 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 22, 2022
@openjdk openjdk bot closed this Mar 22, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 22, 2022
@openjdk
Copy link

openjdk bot commented Mar 22, 2022

@mrserb @srmandal Pushed as commit a6fd0b2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@srmandal srmandal deleted the 8283087 branch October 20, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants