-
Notifications
You must be signed in to change notification settings - Fork 6k
8255036: Shenandoah: Reset GC state for root verifier #781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8255036: Shenandoah: Reset GC state for root verifier #781
Conversation
👋 Welcome back zgu! A progress list of the required criteria for merging this PR into |
@zhengyu123 The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I'd change the commit msg to begin with uppercase after Shenandoah: and form an imperative statement: "Shenandoah: Reset GC state for root verifier"
@zhengyu123 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@zhengyu123 Since your change was applied there have been 2 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit c9269bf. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Shenandoah has ShenandoahGCStateResetter to reset gc state for verifier to avoid triggering barriers inadvertently, root verifier should do the same.
Also, SH::_concurrent_weak_root_in_progress flag now has implication for native barrier, ShenandoahGCStateResetter should reset this flag too.
Progress
Testing
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/781/head:pull/781
$ git checkout pull/781