Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8282633: jarsigner output does not explain why an EC key is disabled if its curve has been disabled #7810

Closed
wants to merge 3 commits into from

Conversation

haimaychao
Copy link
Contributor

@haimaychao haimaychao commented Mar 14, 2022

When a named curve is disabled in jdk.disabled.namedCurves property which is included in jdk.jar.disabledAlgorithms and jdk.certpath.disabledAlgorithms, jarsigner should display the disabled named curve as a result of its disabled algorithm constraint checking. This clarifies why an EC key is disabled in its warning and verbose output.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8282633: jarsigner output does not explain why an EC key is disabled if its curve has been disabled

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7810/head:pull/7810
$ git checkout pull/7810

Update a local copy of the PR:
$ git checkout pull/7810
$ git pull https://git.openjdk.java.net/jdk pull/7810/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7810

View PR using the GUI difftool:
$ git pr show -t 7810

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7810.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 14, 2022

👋 Welcome back hchao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 14, 2022

@haimaychao The following labels will be automatically applied to this pull request:

  • compiler
  • core-libs
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security security-dev@openjdk.org core-libs core-libs-dev@openjdk.org compiler compiler-dev@openjdk.org labels Mar 14, 2022
@haimaychao
Copy link
Contributor Author

/label remove core-libs

@haimaychao
Copy link
Contributor Author

/label remove compiler

@openjdk openjdk bot removed the core-libs core-libs-dev@openjdk.org label Mar 14, 2022
@openjdk
Copy link

openjdk bot commented Mar 14, 2022

@haimaychao
The core-libs label was successfully removed.

@haimaychao haimaychao changed the title Jdk 8282633 8282633: jarsigner output does not explain why an EC key is disabled if its curve has been disabled Mar 14, 2022
@openjdk openjdk bot removed the compiler compiler-dev@openjdk.org label Mar 14, 2022
@openjdk
Copy link

openjdk bot commented Mar 14, 2022

@haimaychao
The compiler label was successfully removed.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 14, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 14, 2022

Webrevs

@wangweij
Copy link
Contributor

I think include jdk.disabled.namedCurves can also appear in the legacy algorithms, so it's likely there should also be a "key.bit.eccurve.weak" for jarsigner.

@haimaychao
Copy link
Contributor Author

Individual name curves could be added to jdk.security.legacyAlgorithms instead of by jdk.disabled.namedCurves, so changed jarsigner to display the named curves in the legacy algorithms.

Copy link
Contributor

@wangweij wangweij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks fine to me. Thanks.

@openjdk
Copy link

openjdk bot commented Mar 15, 2022

@haimaychao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282633: jarsigner output does not explain why an EC key is disabled if its curve has been disabled

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • 4de7201: 8283122: [AIX, s390] UnsafeCopyMemory 'Mismatched' Tests Fail on Big Endian Systems
  • 2cddf3f: 8282887: Potential memory leak in sun.util.locale.provider.HostLocaleProviderAdapterImpl.getNumberPattern() on Windows
  • 710653c: 8254786: java/net/httpclient/CancelRequestTest.java failing intermittently
  • 34d4ffc: 8279317: compiler/jvmci/compilerToVM/DisassembleCodeBlobTest.java assumes immutable code
  • 6013d09: 8268866: Javascript when used in an iframe cannot display search results
  • 5ba5e21: 8282214: Upgrade JQuery to version 3.6.0
  • a244051: 8283062: Uninitialized warnings in libgtest with GCC 11.2
  • 5bf6a7f: 8282691: add jdb "-R" option for passing any argument to the launched debuggee process
  • f66070b: 8282577: ICC_Profile.setData(int, byte[]) invalidates the profile
  • 70bd57e: 8283049: Fix non-singleton LoggerFinder error message: s/on/one
  • ... and 11 more: https://git.openjdk.java.net/jdk/compare/374193b6d2465a356941f9588a0ccf6d97cb76f6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 15, 2022
@haimaychao
Copy link
Contributor Author

@wangweij Thanks for the review.

@haimaychao
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 15, 2022

Going to push as commit f43ffe2.
Since your change was applied there have been 21 commits pushed to the master branch:

  • 4de7201: 8283122: [AIX, s390] UnsafeCopyMemory 'Mismatched' Tests Fail on Big Endian Systems
  • 2cddf3f: 8282887: Potential memory leak in sun.util.locale.provider.HostLocaleProviderAdapterImpl.getNumberPattern() on Windows
  • 710653c: 8254786: java/net/httpclient/CancelRequestTest.java failing intermittently
  • 34d4ffc: 8279317: compiler/jvmci/compilerToVM/DisassembleCodeBlobTest.java assumes immutable code
  • 6013d09: 8268866: Javascript when used in an iframe cannot display search results
  • 5ba5e21: 8282214: Upgrade JQuery to version 3.6.0
  • a244051: 8283062: Uninitialized warnings in libgtest with GCC 11.2
  • 5bf6a7f: 8282691: add jdb "-R" option for passing any argument to the launched debuggee process
  • f66070b: 8282577: ICC_Profile.setData(int, byte[]) invalidates the profile
  • 70bd57e: 8283049: Fix non-singleton LoggerFinder error message: s/on/one
  • ... and 11 more: https://git.openjdk.java.net/jdk/compare/374193b6d2465a356941f9588a0ccf6d97cb76f6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 15, 2022
@openjdk openjdk bot closed this Mar 15, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 15, 2022
@openjdk
Copy link

openjdk bot commented Mar 15, 2022

@haimaychao Pushed as commit f43ffe2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
2 participants