8283217: Leak FcObjectSet in getFontConfigLocations() in fontpath.c

[zhengyu123]

Please review this small patch to fix leaking of FcObjectSet in getFontConfigLocations()

Test:

• jdk_2d

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8283217: Leak FcObjectSet in getFontConfigLocations() in fontpath.c

Reviewers

• Phil Race (@prrace - Reviewer)
• Alexey Ivanov (@aivanov-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7826/head:pull/7826
$ git checkout pull/7826

Update a local copy of the PR:
$ git checkout pull/7826
$ git pull https://git.openjdk.java.net/jdk pull/7826/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7826

View PR using the GUI difftool:
$ git pr show -t 7826

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7826.diff

[bridgekeeper]

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@zhengyu123 The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (754e33b5)
• 00: Full (6caca241)

[openjdk]

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283217: Leak FcObjectSet in getFontConfigLocations() in fontpath.c

Reviewed-by: prr, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 45 new commits pushed to the master branch:

• b617f1d: 8283447: Remove unused LIR_Assembler::_bs
• eb4849e: 8283327: Add methods to save/restore registers when calling into the VM from C1/interpreter barrier code
• fd93015: 8283332: G1: Stricter assertion in G1BlockOffsetTablePart::forward_to_block_containing_addr
• ec62d90: 8283365: G1: Remove duplicate assertions in HeapRegion::oops_on_memregion_seq_iterate_careful
• e709cb0: 8283186: Explicitly pass a third temp register to MacroAssembler::store_heap_oop
• 83a1c90: 8282789: Create a regression test for the JTree usecase of JDK-4618767
• b451273: 8282548: Create a regression test for JDK-4330998
• 8a2d5ab: 8282270: java/awt/Robot Screen Capture tests fail after 8280861
• 4df6742: 8282723: Add constructors taking a cause to JSSE exceptions
• 3f923b8: 8282704: runtime/Thread/StopAtExit.java may leak memory
• ... and 35 more: https://git.openjdk.java.net/jdk/compare/1465ea98b7736b5960a8b546ccc366c3e3260bdd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[zhengyu123]

Friendly ping! May I have a second review.

Thanks,

[zhengyu123]

Thanks, @prrace @aivanov-jdk

[zhengyu123]

/integrate

[openjdk]

Going to push as commit 909986c.
Since your change was applied there have been 45 commits pushed to the master branch:

• b617f1d: 8283447: Remove unused LIR_Assembler::_bs
• eb4849e: 8283327: Add methods to save/restore registers when calling into the VM from C1/interpreter barrier code
• fd93015: 8283332: G1: Stricter assertion in G1BlockOffsetTablePart::forward_to_block_containing_addr
• ec62d90: 8283365: G1: Remove duplicate assertions in HeapRegion::oops_on_memregion_seq_iterate_careful
• e709cb0: 8283186: Explicitly pass a third temp register to MacroAssembler::store_heap_oop
• 83a1c90: 8282789: Create a regression test for the JTree usecase of JDK-4618767
• b451273: 8282548: Create a regression test for JDK-4330998
• 8a2d5ab: 8282270: java/awt/Robot Screen Capture tests fail after 8280861
• 4df6742: 8282723: Add constructors taking a cause to JSSE exceptions
• 3f923b8: 8282704: runtime/Thread/StopAtExit.java may leak memory
• ... and 35 more: https://git.openjdk.java.net/jdk/compare/1465ea98b7736b5960a8b546ccc366c3e3260bdd...master

Your commit was automatically rebased without conflicts.

[openjdk]

@zhengyu123 Pushed as commit 909986c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.