Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8255129: [PPC64, s390] Check vector_size_supported and add VectorReinterpret node #783

Closed

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Oct 21, 2020

match_rule_supported_vector on PPC64 and s390 need to check vector_size_supported.
In addition, an implementation for VectorReinterpret is needed. It can get implemented empty when using src = dst register. Note that these 2 platforms support only one vector size at a time, so there's no need for move between different sizes.

I'd like to clean up match_rule_supported, too. Cases for which we return true don't need to get checked explicitely because true is default. And we don't need to check SpecialString... flags because they are handled by "disabled_by_jvm_flags". So they can still get disabled (e.g. by jdk/bin/java -XX:-TieredCompilation -XX:-SpecialStringIndexOf -XX:+PrintCompilation -XX:+PrintInlining TestString|grep StringLatin1::indexOf).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x32 Linux x64 Windows x64 macOS x64
Build ✔️ (1/1 passed) ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) (1/9 failed) ✔️ (9/9 passed)

Failed test task

Issue

  • JDK-8255129: [PPC64, s390] Check vector_size_supported and add VectorReinterpret node

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/783/head:pull/783
$ git checkout pull/783

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 21, 2020

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 21, 2020
@openjdk
Copy link

openjdk bot commented Oct 21, 2020

@TheRealMDoerr The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Oct 21, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 21, 2020

Webrevs

Copy link
Contributor

@RealLucy RealLucy left a comment

Martin,
these changes look good to me. There remains a lot to be implemented, though. :-) And thank you for cleaning up the code!
Best, Lutz

@openjdk
Copy link

openjdk bot commented Oct 22, 2020

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255129: [PPC64, s390] Check vector_size_supported and add VectorReinterpret node

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • 211bb62: 8255124: KeepAliveStreamCleaner may crash with java.lang.IllegalMonitorStateException: current thread is not owner
  • 299e115: 8198395: Test javax/swing/plaf/metal/MetalLookAndFeel/Test8039750.java fails in mach5
  • a5b7bc5: 7156347: javax/swing/JList/6462008/bug6462008.java fails
  • b25d894: 8252204: AArch64: Implement SHA3 accelerator/intrinsic
  • 7d3d4da: 8240709: Enable javax/swing/UI/UnninstallUIMemoryLeaks/UnninstallUIMemoryLeaks.java on all L&F
  • 5d26229: 8255174: Vector API unit tests for missed public api code coverage
  • b9186be: 6606767: resexhausted00[34] fail assert(!thread->owns_locks(), "must release all locks when leaving VM")
  • 1191a63: 8199697: FIPS 186-4 RSA Key Generation
  • 60d3fa2: 8255022: Documentation missing for Vector API zero methods
  • 9ade94b: 8206311: Add docs-javase, docs-reference to CI build
  • ... and 11 more: https://git.openjdk.java.net/jdk/compare/e559bd2c8bf64888c8890605839d909228c97aaa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 22, 2020
@TheRealMDoerr
Copy link
Contributor Author

TheRealMDoerr commented Oct 23, 2020

/integrate

@openjdk openjdk bot closed this Oct 23, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 23, 2020
@TheRealMDoerr TheRealMDoerr deleted the 8255129_ppc_s390_vector branch Oct 23, 2020
@openjdk
Copy link

openjdk bot commented Oct 23, 2020

@TheRealMDoerr Since your change was applied there have been 44 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 9007bc2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
2 participants