-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8255129: [PPC64, s390] Check vector_size_supported and add VectorReinterpret node #783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8255129: [PPC64, s390] Check vector_size_supported and add VectorReinterpret node #783
Conversation
👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into |
@TheRealMDoerr The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Martin,
these changes look good to me. There remains a lot to be implemented, though. :-) And thank you for cleaning up the code!
Best, Lutz
@TheRealMDoerr This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 21 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
@TheRealMDoerr Since your change was applied there have been 44 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 9007bc2. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
match_rule_supported_vector on PPC64 and s390 need to check vector_size_supported.
In addition, an implementation for VectorReinterpret is needed. It can get implemented empty when using src = dst register. Note that these 2 platforms support only one vector size at a time, so there's no need for move between different sizes.
I'd like to clean up match_rule_supported, too. Cases for which we return true don't need to get checked explicitely because true is default. And we don't need to check SpecialString... flags because they are handled by "disabled_by_jvm_flags". So they can still get disabled (e.g. by jdk/bin/java -XX:-TieredCompilation -XX:-SpecialStringIndexOf -XX:+PrintCompilation -XX:+PrintInlining TestString|grep StringLatin1::indexOf).
Progress
Testing
Failed test task
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/783/head:pull/783
$ git checkout pull/783