8283188: Build time regression caused by JDK-8278917

[albertnetymk]

Move G1CollectedHeap::mark_evac_failure_object to cpp so that g1CollectedHeap.inline.hpp doesn't need to include g1ConcurrentMark.inline.hpp.

With the patch, the build time of clean fastdebug is reduced by ~16s.

Before: 6:25.72
After: 6:09.76

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8283188: Build time regression caused by JDK-8278917

Reviewers

• Kim Barrett (@kimbarrett - Reviewer)
• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7839/head:pull/7839
$ git checkout pull/7839

Update a local copy of the PR:
$ git checkout pull/7839
$ git pull https://git.openjdk.java.net/jdk pull/7839/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7839

View PR using the GUI difftool:
$ git pr show -t 7839

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7839.diff

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1d08ab26)

[kimbarrett]

Looks good.

I was curious, so a dug into the data a bit. According to the build system's generated .d files, this removes 61 files from transitive closure of the includes for g1CollectedHeap.inline.hpp, some of them fairly large. And g1CollectedHeap.inline.hpp is itself included 59 times.

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283188: Build time regression caused by JDK-8278917

Reviewed-by: kbarrett, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 0f1766d: 8283320: Error message for Windows libraries always points to --with-msvcr-dll no matter the actual file name
• 69e4e33: 8283056: show abstract machine code in hs-err for all VM crashes
• bad658e: 8282727: Parallel: Remove PSPromotionManager::_totally_drain
• beedae1: 8281146: Replace StringCoding.hasNegatives with countPositives
• 249d553: 8282602: Refactor awt classes javadoc to use @throws instead of @exception
• 096bca4: 8282473: Refactor swing classes javadoc to use @throws instead of @exception
• a5ebcc0: 8282072: G1: Rename CardSetPtr to CardSetContainerPtr
• 3da5204: 8283229: compiler/arguments/TestCodeEntryAlignment.java fails with release VMs
• 3e39304: 8281631: HashMap copy constructor and putAll can over-allocate table
• 0cf291b: 8283234: Improve @jls usage in java.base
• ... and 1 more: https://git.openjdk.java.net/jdk/compare/08cadb4754da0d5e68ee2df45f4098d203d14115...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[albertnetymk]

Thanks for the review.

/integrate

[openjdk]

Going to push as commit 31df6a6.
Since your change was applied there have been 11 commits pushed to the master branch:

• 0f1766d: 8283320: Error message for Windows libraries always points to --with-msvcr-dll no matter the actual file name
• 69e4e33: 8283056: show abstract machine code in hs-err for all VM crashes
• bad658e: 8282727: Parallel: Remove PSPromotionManager::_totally_drain
• beedae1: 8281146: Replace StringCoding.hasNegatives with countPositives
• 249d553: 8282602: Refactor awt classes javadoc to use @throws instead of @exception
• 096bca4: 8282473: Refactor swing classes javadoc to use @throws instead of @exception
• a5ebcc0: 8282072: G1: Rename CardSetPtr to CardSetContainerPtr
• 3da5204: 8283229: compiler/arguments/TestCodeEntryAlignment.java fails with release VMs
• 3e39304: 8281631: HashMap copy constructor and putAll can over-allocate table
• 0cf291b: 8283234: Improve @jls usage in java.base
• ... and 1 more: https://git.openjdk.java.net/jdk/compare/08cadb4754da0d5e68ee2df45f4098d203d14115...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit 31df6a6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.