Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283277: ISO 4217 Amendment 171 Update #7857

Closed
wants to merge 1 commit into from

Conversation

naotoj
Copy link
Member

@naotoj naotoj commented Mar 17, 2022

This is to incorporate the ISO 4217 amendment 171 for Sierra Leonean LEONE redenomination (removing 3 zeros). Its effective date is 4/1, but I went ahead as JDK19 won't be released by 4/1.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7857/head:pull/7857
$ git checkout pull/7857

Update a local copy of the PR:
$ git checkout pull/7857
$ git pull https://git.openjdk.java.net/jdk pull/7857/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7857

View PR using the GUI difftool:
$ git pr show -t 7857

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7857.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 17, 2022

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 17, 2022

@naotoj The following labels will be automatically applied to this pull request:

  • build
  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Mar 17, 2022
@naotoj naotoj marked this pull request as ready for review March 17, 2022 18:31
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 17, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 17, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 17, 2022

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283277: ISO 4217 Amendment 171 Update

Reviewed-by: iris, joehw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 38 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 17, 2022
@naotoj
Copy link
Member Author

naotoj commented Mar 21, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Mar 21, 2022

Going to push as commit c4dc58e.
Since your change was applied there have been 65 commits pushed to the master branch:

  • cb576da: 8283379: Memory leak in FileHeaderHelper
  • 909986c: 8283217: Leak FcObjectSet in getFontConfigLocations() in fontpath.c
  • b617f1d: 8283447: Remove unused LIR_Assembler::_bs
  • eb4849e: 8283327: Add methods to save/restore registers when calling into the VM from C1/interpreter barrier code
  • fd93015: 8283332: G1: Stricter assertion in G1BlockOffsetTablePart::forward_to_block_containing_addr
  • ec62d90: 8283365: G1: Remove duplicate assertions in HeapRegion::oops_on_memregion_seq_iterate_careful
  • e709cb0: 8283186: Explicitly pass a third temp register to MacroAssembler::store_heap_oop
  • 83a1c90: 8282789: Create a regression test for the JTree usecase of JDK-4618767
  • b451273: 8282548: Create a regression test for JDK-4330998
  • 8a2d5ab: 8282270: java/awt/Robot Screen Capture tests fail after 8280861
  • ... and 55 more: https://git.openjdk.java.net/jdk/compare/c96085eaab1f6b21e084b94fcc619d090f0afc97...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 21, 2022
@openjdk openjdk bot closed this Mar 21, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 21, 2022
@openjdk
Copy link

openjdk bot commented Mar 21, 2022

@naotoj Pushed as commit c4dc58e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants