Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252117: com/sun/jdi/BadHandshakeTest.java failed with "ConnectException: Connection refused: connect" #789

Closed
wants to merge 2 commits into from

Conversation

@alexmenkov
Copy link

@alexmenkov alexmenkov commented Oct 22, 2020

Please review the fix for BadHandshakeTest.
Summary:
The test verifies that bad (testcase1) or incomplete (testcase2) handshake does not cause debuggee termination.
To check this it tries to attach to the debuggee again (connect in testcase2 is also verification for testcase1)

The fix adds reply logic to the last attach (similar to retry logic in testcase2)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252117: com/sun/jdi/BadHandshakeTest.java failed with "ConnectException: Connection refused: connect"

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/789/head:pull/789
$ git checkout pull/789

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 22, 2020

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Oct 22, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 22, 2020

@alexmenkov The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 22, 2020

Webrevs

Loading

Copy link
Contributor

@plummercj plummercj left a comment

Other than the one comment I noted, the changes look good. Was the failure rate high enough that you've been able to prove your fix works?

Loading

vm.eventRequestManager().deleteAllBreakpoints();
vm.resume();

// get the debuggee some time to exit before forcibly terminate it
Copy link
Contributor

@plummercj plummercj Oct 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"give", not "get". Also, "terminating", not "terminate".

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 23, 2020

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8252117: com/sun/jdi/BadHandshakeTest.java failed with "ConnectException: Connection refused: connect"

Reviewed-by: cjplummer, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 53 new commits pushed to the master branch:

  • 83a91bf: 8253734: C2: Optimize Move nodes
  • 6666dcb: 8237363: Remove automatic is in heap verification in OopIterateClosure
  • fa64477: 8255301: Common and strengthen the code in ciMemberName and ciMethodHandle
  • 9b5a2a6: 8255349: Vector API issues on Big Endian
  • e8b75b1: 8255393: sun/security/util/DerValue/Indefinite.java fails with ---illegal-access=deny
  • 7cafe35: 8255352: Archive important test outputs in submit workflow
  • 888086f: 8255373: Submit workflow artifact name is always "test-results_.zip"
  • 6918818: 8255265: IdealLoopTree::iteration_split_impl does not use should_align
  • c28b011: 8255343: java/util/stream/SpliteratorTest.java fails on 32-bit platforms with "Misaligned access at address: 12"
  • b71b5b4: 8199062: Test javax/swing/text/Utilities/8134721/bug8134721.java is unstable
  • ... and 43 more: https://git.openjdk.java.net/jdk/compare/b9186bebc34a814e411a441e7ad4af8e6e6ed04a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Oct 23, 2020
Copy link
Contributor

@sspitsyn sspitsyn left a comment

Hi Alex,
It looks good.
Thanks,
Serguei

Loading

@alexmenkov
Copy link
Author

@alexmenkov alexmenkov commented Oct 27, 2020

/integrate

Loading

@openjdk openjdk bot closed this Oct 27, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 27, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 27, 2020

@alexmenkov Since your change was applied there have been 76 commits pushed to the master branch:

  • 7a7ce02: 8007632: DES/3DES keys support in PKCS12 keystore
  • a023b93: 8255394: jdk/test/lib/hexdump/ASN1FormatterTest.java fails with ---illegal-access=deny
  • 84e985d: 8253920: Share method trampolines in CDS dynamic archive
  • 7d41a54: 8255450: runtime/ThreadCountLimit.java causes high system load
  • 504cb00: 8252113: Move jfr man page into jfr module
  • 552192f: 8255305: Add Linux x86_32 tier1 to submit workflow
  • 66a3917: 8255331: Problemlist java/foreign/TestMismatch.java on 32-bit platforms until JDK-8254162
  • cf56c7e: 8254980: ZGC: ZHeapIterator visits armed nmethods with -XX:-ClassUnloading
  • 18d9905: 8255342: Remove non-specified JVM checks on Classes with Record attributes
  • 7679650: 8231231: The printing result is different from the case instruction
  • ... and 66 more: https://git.openjdk.java.net/jdk/compare/b9186bebc34a814e411a441e7ad4af8e6e6ed04a...master

Your commit was automatically rebased without conflicts.

Pushed as commit 1d245c6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@alexmenkov alexmenkov deleted the BadHandshake branch Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants