Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283456: Make CompiledICHolder::live_count/live_not_claimed_count debug only #7890

Closed

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Mar 21, 2022

Please review this trivial patch to make CompiledICHolder::live_count/live_not_claimed_count debug only, since they are only updated/used in debug only code.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8283456: Make CompiledICHolder::live_count/live_not_claimed_count debug only

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7890/head:pull/7890
$ git checkout pull/7890

Update a local copy of the PR:
$ git checkout pull/7890
$ git pull https://git.openjdk.java.net/jdk pull/7890/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7890

View PR using the GUI difftool:
$ git pr show -t 7890

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7890.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 21, 2022

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 21, 2022
@openjdk
Copy link

openjdk bot commented Mar 21, 2022

@zhengyu123 The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot label Mar 21, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 21, 2022

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Seems fine and trivial.

Thanks,
David

@openjdk
Copy link

openjdk bot commented Mar 22, 2022

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283456: Make CompiledICHolder::live_count/live_not_claimed_count debug only

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 849b195: 8282937: Write a regression test for JDK-4820080
  • 81d6373: 8282469: Allow considered use of C++ thread_local in Hotspot
  • f3dc0c8: 8282721: HotSpot Style Guide should allow considered use of C++ thread_local
  • f8878cb: 8257733: Move module-specific data from make to respective module
  • 14b9e80: 8283415: Update java.lang.ref to use sealed classes
  • f4f8728: 8283097: Parallel: Move filler object logic inside PSPromotionLAB::unallocate_object
  • 19d34bd: 8281879: Serial: Merge CardGeneration into TenuredGeneration
  • 999da9b: 8282306: os::is_first_C_frame(frame*) crashes on invalid link access
  • c4dc58e: 8283277: ISO 4217 Amendment 171 Update

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 22, 2022
@zhengyu123
Copy link
Contributor Author

zhengyu123 commented Mar 22, 2022

Thanks, @dholmes-ora

@zhengyu123
Copy link
Contributor Author

zhengyu123 commented Mar 22, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Mar 22, 2022

Going to push as commit c0f984e.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 85628a8: 8282592: C2: assert(false) failed: graph should be schedulable
  • a6fd0b2: 8283087: Create a test or JDK-4715503
  • 37fc77e: 8283092: JMX subclass permission check redundant with strong encapsulation
  • 849b195: 8282937: Write a regression test for JDK-4820080
  • 81d6373: 8282469: Allow considered use of C++ thread_local in Hotspot
  • f3dc0c8: 8282721: HotSpot Style Guide should allow considered use of C++ thread_local
  • f8878cb: 8257733: Move module-specific data from make to respective module
  • 14b9e80: 8283415: Update java.lang.ref to use sealed classes
  • f4f8728: 8283097: Parallel: Move filler object logic inside PSPromotionLAB::unallocate_object
  • 19d34bd: 8281879: Serial: Merge CardGeneration into TenuredGeneration
  • ... and 2 more: https://git.openjdk.java.net/jdk/compare/cb576da575ea3c8f14087dd312313843764ca2f4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Mar 22, 2022
@openjdk openjdk bot closed this Mar 22, 2022
@openjdk openjdk bot removed ready rfr labels Mar 22, 2022
@openjdk
Copy link

openjdk bot commented Mar 22, 2022

@zhengyu123 Pushed as commit c0f984e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot integrated
2 participants